Skip to contentSkip to conversation

usb: printer double up()

PATCH Pete Zaitcev 1 participant 1 message Jul 25, 2005 USB

lore
Share & tools
lore
#0 lore raw

Doing a double up() is actually safe in Linux, but still, it's a bug. This fix is present in 2.6.13-rc3.

By Domen Puncer <[email protected]> up(&usblp->sem) was called twice in a row in this code path.

drivers/usb/printer.c +1 -0
@@ -740,6 +740,7 @@ static ssize_t usblp_read(struct file *f
 				schedule();
 			} else {
 				set_current_state(TASK_RUNNING);
+				down (&usblp->sem);
 				break;
 			}
 			down (&usblp->sem);