Skip to contentSkip to conversation

Fix compilation in locomo.c

PATCH In review Pavel Machek 4 participants 4 messages Jul 26, 2005 – Sep 8, 2005 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix compilation in locomo.c

Do not access children in struct device directly, use device_for_each_child helper instead. It fixes compilation.

---
commit 3d7f15c66bc66c480d468e2c4d623949bba0d41f tree 9734f5a58c31dade74b1b35c1ce0b0d6d44da589 parent 6cd7322dce560001570713269630390754881e5d author <pavel@amd.(none)> Tue, 26 Jul 2005 08:29:38 +0200 committer <pavel@amd.(none)> Tue, 26 Jul 2005 08:29:38 +0200

 arch/arm/common/locomo.c |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)
arch/arm/common/locomo.c +7 -7
@@ -651,15 +651,15 @@ __locomo_probe(struct device *me, struct
 	return ret;
 }
 
-static void __locomo_remove(struct locomo *lchip)
+static int locomo_remove_child(struct device *dev, void *data)
 {
-	struct list_head *l, *n;
-
-	list_for_each_safe(l, n, &lchip->dev->children) {
-		struct device *d = list_to_dev(l);
+	device_unregister(dev);
+	return 0;
+} 
 
-		device_unregister(d);
-	}
+static void __locomo_remove(struct locomo *lchip)
+{
+	device_for_each_child(lchip->dev, NULL, locomo_remove_child);
 
 	if (lchip->irq != NO_IRQ) {
 		set_irq_chained_handler(lchip->irq, NULL);
Signature · 1 line
teflon -- maybe it is a trademark, but it should not be.
#1 lore raw
Quoted 4 lines · Pavel Machek

Do not access children in struct device directly, use device_for_each_child helper instead. It fixes compilation.

Given up waiting for John/Richard to okay this, applied anyway.

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
#2 lore raw
Quoted 7 lines · Russell King
Quoted 4 lines · Pavel Machek

Do not access children in struct device directly, use device_for_each_child helper instead. It fixes compilation.

Given up waiting for John/Richard to okay this, applied anyway.

You did get a response from me on 20/8/05 which said:

"Locomo is outside my area of expertise and its not present on the devices I use/maintain, hence this is something John would have the definitive opinion on. The patch looks sane to me though."

I suspect John is between email addresses at the moment. Hopefully he'll be back with us soon.

Richard

#3 lore raw
Quoted 9 lines · Richard Purdie
Quoted 7 lines · Russell King
Quoted 4 lines · Pavel Machek

Do not access children in struct device directly, use device_for_each_child helper instead. It fixes compilation.

Given up waiting for John/Richard to okay this, applied anyway.

Quoted 8 lines

You did get a response from me on 20/8/05 which said:

"Locomo is outside my area of expertise and its not present on the devices I use/maintain, hence this is something John would have the definitive opinion on. The patch looks sane to me though."

I suspect John is between email addresses at the moment. Hopefully he'll be back with us soon.

Yeah... I'm now back but haven't yet had a chance to look at any patches or anything that has been floating around. Next week I will look closer at these patches (even if they have already been applied).

John