Skip to contentSkip to conversation

Bug#320379: Errors during initrd loading when / is on LVM over RAID

DISCUSSION Horms 2 participants 2 messages Aug 3, 2005 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Horms

author
#1 lore raw
Quoted 62 lines · Frans Pop

Package: kernel
Tags: patch

After switching from a 2.4.27 to 2.6.8 kernel for an old desktop Iuse as a server, I noticed the following messages on console and kern.log.
Note: the errors are not harmful, just ugly; the system boots normally.

kernel: Inspecting /boot/System.map-2.6.8-2-686
kernel: Loaded 27390 symbols from /boot/System.map-2.6.8-2-686.
kernel: Symbols match kernel version 2.6.8.
kernel: No module symbols loaded - kernel modules not enabled.
kernel: ould not append to parent for /disc
kernel: devfs_mk_dir: invalid argument.<4>devfs_mk_dev: could not append to parent for /disc last message repeated 151 times

Cleaned for a missing \n in a printk and with added debug printk's in fs/devfs/base.c, this looks like:
kernel: devfs_mk_dir: invalid argument, buf: .
kernel: _devfs_append_entry: -EEXIST for :disc
kernel: devfs_mk_dev: could not append to parent for /disc (repeated)

The last error is a consequence of the error in devfs_mk_dir, so can be ignored. The basic problem is that buf is empty.

Tracing back I ended up in fs/partitions/check.c, which has the following code in function register_disk:

	/* No minors to use for partitions */
	if (disk->minors == 1) {
		if (disk->devfs_name[0] != '\0')
			devfs_add_disk(disk);
		return;
	}

	/* always add handle for the whole disk */
	devfs_add_partitioned(disk);

This looks unlogical: why does the first statement check for empty disk->devfs_name and is the second one called blindly?

Changing the last statement to:

	if (disk->devfs_name[0] != '\0')
		devfs_add_partitioned(disk);
	else
		printk(KERN_WARNING "%s: No devfs_name for %s.\n", __FUNCTION__, disk->disk_name);

resulted in the errors disappearing and the following log output:

kernel: register_disk: No devfs_name for md_d0.
kernel: register_disk: No devfs_name for md_d64.
kernel: register_disk: No devfs_name for md_d128.
kernel: register_disk: No devfs_name for md_d192.
kernel: register_disk: No devfs_name for md_d4.
kernel: register_disk: No devfs_name for md_d68.
kernel: register_disk: No devfs_name for md_d132.
kernel: register_disk: No devfs_name for md_d196.
(repeated to md_d255)

I've debugged using kernel version 2.6.8, but a check showed this code is unchanged in 2.6.11 and 2.6.12.

Quoted 6 lines

Please review my reasoning. If I'm correct, the attached patch may fix the errors (and fix the missing \n). If you think the patch is correct, I would appreciate advice how best to get it upstream.
The other option would of course be that something is more fundamentally broken and that disk->devfs_name should be filled in these cases, but I doubt that.

Hi Frans,

The null devfs_name check seems fine to me,
I've CCed Richard Gooch for comment, hopefully
he can offer one despite devfs being debricated
upstream.

The \n fix is obviously ok, but again its going away upstream, so I doubt they care, and I'm not excited about this kind of fix for Sarge.

Quoted 28 lines

Cheers,
FJP

partitions/check.c renamed from partitions/check.c.orig +2 -1
@@ -348,7 +348,8 @@
 	}
 
 	/* always add handle for the whole disk */
-	devfs_add_partitioned(disk);
+	if (disk->devfs_name[0] != '\0')
+		devfs_add_partitioned(disk);
 
 	/* No such device (e.g., media were just removed) */
 	if (!get_capacity(disk))
devfs/base.c renamed from devfs/base.c.orig +1 -1
@@ -1644,7 +1644,7 @@
 	va_start(args, fmt);
 	n = vsnprintf(buf, 64, fmt, args);
 	if (n >= 64 || !buf[0]) {
-		printk(KERN_WARNING "%s: invalid argument.", __FUNCTION__);
+		printk(KERN_WARNING "%s: invalid argument.\n", __FUNCTION__);
 		return -EINVAL;
 	}
 
Signature · 1 line
Horms
#2 lore raw
Quoted 8 lines · Horms

...
Hi Frans,

The null devfs_name check seems fine to me,
I've CCed Richard Gooch for comment, hopefully
he can offer one despite devfs being debricated
upstream.
...

The DEVFS_FS config option is no longer available in 2.6.13 making any fixes to devfs pointless.

Quoted 1 line

Horms

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed