Skip to contentSkip to conversation

2.6.13-rc4-git3: snd_intel8x0: handle irq_request failure on resume

PATCH In review Rafael J. Wysocki 2 participants 3 messages Jul 31, 2005 – Aug 1, 2005 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 2.6.13-rc4-git3: snd_intel8x0: handle irq_request failure on resume

Hi,

This patch adds the handling of irq_request() failures during resume to the snd_intel8x0 driver.

Please consider for applying,
Rafael

sound/pci/intel8x0.c +6 -1
@@ -2390,7 +2390,12 @@ static int intel8x0_resume(snd_card_t *c
 
 	pci_enable_device(chip->pci);
 	pci_set_master(chip->pci);
-	request_irq(chip->irq, snd_intel8x0_interrupt, SA_INTERRUPT|SA_SHIRQ, card->shortname, (void *)chip);
+	if (request_irq(chip->irq, snd_intel8x0_interrupt, SA_INTERRUPT|SA_SHIRQ, card->shortname, (void *)chip)) {
+		snd_printk("unable to grab IRQ %d\n", chip->irq);
+		chip->irq = -1;
+		pci_disable_device(chip->pci);
+		return -EBUSY;
+	}
 	synchronize_irq(chip->irq);
 	snd_intel8x0_chip_init(chip, 1);
 
#1 lore raw

Hi Rafael,

At Sun, 31 Jul 2005 12:43:21 +0200,

Quoted 8 lines · Rafael J. Wysocki

Hi,

This patch adds the handling of irq_request() failures during resume to the snd_intel8x0 driver.

Please consider for applying,
Rafael

Not directly with the patch but I have a question about your first patch. I found you changed from the second argument of snd_intel8x0_chip_init() from 0 to 1. Is it intentional?

Takashi

#2 lore raw
Quoted 10 lines · Takashi Iwai

Hi Rafael,

At Sun, 31 Jul 2005 12:43:21 +0200,

Quoted 6 lines · Rafael J. Wysocki

Hi,

This patch adds the handling of irq_request() failures during resume to the snd_intel8x0 driver.

Quoted 6 lines
Quoted 2 lines

Please consider for applying,
Rafael

Not directly with the patch but I have a question about your first patch. I found you changed from the second argument of snd_intel8x0_chip_init() from 0 to 1. Is it intentional?

Yes. My box hangs solid while executing snd_intel8x0_chip_init(0) after requesting the IRQ in _resume().

Greets,
Rafael

Signature · 3 lines
- Would you tell me, please, which way I ought to go from here?
- That depends a good deal on where you want to get to.
		-- Lewis Carroll "Alice's Adventures in Wonderland"