rfc about an uncommented string
Hi.
I'd like to collect some comments about the following code segment I found in linux-2.6.13-rc6/arch/mips/ite-boards/generic/it8172_setup.c (the "^^^" sequence is not mine, it's in the code)
#ifdef CONFIG_SERIO_I8042
/*
* According to the ITE Special BIOS Note for waking up the
* keyboard controller...
*/
static int init_8712_keyboard(void)
{
unsigned int cmd_port = 0x14000064;
unsigned int data_port = 0x14000060;
^^^^^^^^^^^
Somebody here doesn't grok the concept of io ports.Signature · 1 line
Carlo Perassi - http://www.linux.it/~carlo/
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
this will break if CONFIG_SERIO_I8042 is set and i guess intentionaly.
who checked that in ? perhaps the mips ppl know about it.
re,
walter
Quoted 21 lines · Carlo Perassi
Hi.
I'd like to collect some comments about the following code segment I found in
linux-2.6.13-rc6/arch/mips/ite-boards/generic/it8172_setup.c(the "^^^" sequence is not mine, it's in the code)#ifdef
CONFIG_SERIO_I8042
/*
* According to the ITE Special BIOS Note for waking up the
* keyboard controller...
*/
static intinit_8172_keyboard(void){ unsigned int cmd_port = 0x14000064; unsigned int data_port = 0x14000060; ^^^^^^^^^^^ Somebody here doesn't grok the concept of io ports.
Quoted 6 lines
------------------------------------------------------------------------
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 1 line
this will break if
CONFIG_SERIO_I8042is set and i guess intentionaly.
I think so but I guess it is not the standard way to let the user know CONFIG_SERIO_I8042 is broken.
Quoted 1 line
who checked that in ? perhaps the mips ppl know about it.
What do you suggest to do?
Thank you.
Signature · 6 lines
Carlo Perassi - http://www.linux.it/~carlo/ _______________________________________________ Kernel-janitors mailing list [email protected] https://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 9 lines · Carlo Perassi
Quoted 1 line
this will break if
CONFIG_SERIO_I8042is set and i guess intentionaly.I think so but I guess it is not the standard way to let the user know
CONFIG_SERIO_I8042is broken.Quoted 1 line
who checked that in ? perhaps the mips ppl know about it.
What do you suggest to do?
Thank you.
Bounce it to <[email protected]>? The delta between the mainline and linux-mips git trees is quite huge, and that particular piece of code is still present in both..
Arthur
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors