Skip to contentSkip to conversation

support for Si3054/5 HDA modems

PATCH In review Sasha Khapyorsky 2 participants 4 messages Aug 10, 2005 – Aug 11, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 support for Si3054/5 HDA modems

Hello,

This patch adds support for Si3054/5 HDA modem codecs.

Sasha.

Support for Si3054/5 HDA modem codecs.

Index: alsa-kernel/pci/hda/Makefile
===================================================================
RCS file: /cvsroot/alsa/alsa-kernel/pci/hda/Makefile,v retrieving revision 1.3

pci/hda/Makefile +1 -1
diff -u -p -u -p -r1.3 Makefile
@@ -1,5 +1,5 @@
 snd-hda-intel-objs := hda_intel.o
-snd-hda-codec-objs := hda_codec.o hda_generic.o patch_realtek.o patch_cmedia.o patch_analog.o patch_sigmatel.o
+snd-hda-codec-objs := hda_codec.o hda_generic.o patch_realtek.o patch_cmedia.o patch_analog.o patch_sigmatel.o patch_si3054.o
 ifdef CONFIG_PROC_FS
 snd-hda-codec-objs += hda_proc.o
 endif

Index: alsa-kernel/pci/hda/hda_patch.h
===================================================================
RCS file: /cvsroot/alsa/alsa-kernel/pci/hda/hda_patch.h,v retrieving revision 1.3

pci/hda/hda_patch.h +3 -0
diff -u -p -u -p -r1.3 hda_patch.h
@@ -10,11 +10,14 @@ extern struct hda_codec_preset snd_hda_p
 extern struct hda_codec_preset snd_hda_preset_analog[];
 /* SigmaTel codecs */
 extern struct hda_codec_preset snd_hda_preset_sigmatel[];
+/* SiLabs 3054/3055 modem codecs */
+extern struct hda_codec_preset snd_hda_preset_si3054[];
 
 static const struct hda_codec_preset *hda_preset_tables[] = {
 	snd_hda_preset_realtek,
 	snd_hda_preset_cmedia,
 	snd_hda_preset_analog,
 	snd_hda_preset_sigmatel,
+	snd_hda_preset_si3054,
 	NULL
 };

Index: alsa-kernel/pci/hda/patch_si3054.c
===================================================================
RCS file: alsa-kernel/pci/hda/patch_si3054.c

pci/hda/patch_si3054.c new file +300 -0

300 lines not on this page · raw message

Index: alsa-driver/pci/hda/patch_si3054.c
===================================================================
RCS file: alsa-driver/pci/hda/patch_si3054.c

pci/hda/patch_si3054.c new file +2 -0
diff -N alsa-driver/pci/hda/patch_si3054.c
@@ -0,0 +1,2 @@
+#define __NO_VERSION__
+#include "../../alsa-kernel/pci/hda/patch_si3054.c"

-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

#1 lore raw

At Wed, 10 Aug 2005 22:47:45 +0300,

Quoted 11 lines · Sasha Khapyorsky

Hello,

This patch adds support for Si3054/5 HDA modem codecs.

Sasha.

Support for Si3054/5 HDA modem codecs.

Great! Is it supposed to work with slmodem?
Then we'll need a definition of modem PCM for hda-intel, right?

Currently, we assume that the codec order is fixed and the number is assigned statically in the config. It will be necessary to improve this probing.

Takashi

-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

#2 lore raw

At Thu, 11 Aug 2005 11:41:17 +0200,

Quoted 13 lines · 私 wrote:

At Wed, 10 Aug 2005 22:47:45 +0300,

Quoted 10 lines · Sasha Khapyorsky

Hello,

This patch adds support for Si3054/5 HDA modem codecs.

Sasha.

Support for Si3054/5 HDA modem codecs.

Quoted 8 lines
Quoted 1 line

Great! Is it supposed to work with slmodem?
Then we'll need a definition of modem PCM for hda-intel, right?

Currently, we assume that the codec order is fixed and the number is assigned statically in the config. It will be necessary to improve this probing.

The patches were committed to CVS, BTW. Thanks!

Takashi

-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

#3 lore raw
In reply to Takashi Iwai
Quoted 2 lines · Takashi Iwai

Great! Is it supposed to work with slmodem?

Yes, as full featured modem emulation.

Of course it is usable with aplay, arecord, amixer, whatever too.

Quoted 1 line

Then we'll need a definition of modem PCM for hda-intel, right?

Yes, I missed this. (I traditionally use 'aplay -l' and then choose right device).

Quoted 3 lines

Currently, we assume that the codec order is fixed and the number is assigned statically in the config. It will be necessary to improve this probing.

Good idea.

Sasha.

-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf