Skip to contentSkip to conversation

kernel spams syslog every 10 sec with w1 debug

PATCH In review Olaf Hering 2 participants 2 messages Aug 12, 2005 W1 dallas's 1-wire bus

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel spams syslog every 10 sec with w1 debug

Bug 104020 - kernel spams syslog every 10 sec with: w1_driver w1_bus_master1: No devices present on the wire.

After installing 10.0 B1, I found this in my syslog:

Aug 10 23:40:06 linux kernel: w1_driver w1_bus_master1: No devices present on the wire. 
Aug 10 23:40:16 linux kernel: w1_driver w1_bus_master1: No devices present on the wire. 
 drivers/w1/w1.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)
drivers/w1/w1.c +2 -1
Index: linux-2.6.13-rc6-aes/drivers/w1/w1.c
===================================================================
@@ -593,7 +593,8 @@ void w1_search(struct w1_master *dev, w1
 		 * Return 0 - device(s) present, 1 - no devices present.
 		 */
 		if (w1_reset_bus(dev)) {
-			dev_info(&dev->dev, "No devices present on the wire.\n");
+			if (printk_ratelimit())
+				dev_debug(&dev->dev, "No devices present on the wire.\n");
 			break;
 		}
 
#1 lore raw
Quoted 17 lines · Olaf Hering

Bug 104020 - kernel spams syslog every 10 sec with: w1_driver w1_bus_master1: No devices present on the wire.

After installing 10.0 B1, I found this in my syslog:

Aug 10 23:40:06 linux kernel: w1_driver w1_bus_master1: No devices present on the wire. 
Aug 10 23:40:16 linux kernel: w1_driver w1_bus_master1: No devices present on the wire. 
 drivers/w1/w1.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

Index: linux-2.6.13-rc6-aes/drivers/w1/w1.c
===================================================================

drivers/w1/w1.c void w1_search(struct w1_master *dev, w1 · line 599

Quoted 8 lines
drivers/w1/w1.c +2 -1
@@ -593,7 +593,8 @@ void w1_search(struct w1_master *dev, w1
 		 * Return 0 - device(s) present, 1 - no devices present.
 		 */
 		if (w1_reset_bus(dev)) {
-			dev_info(&dev->dev, "No devices present on the wire.\n");
+			if (printk_ratelimit())
+				dev_debug(&dev->dev, "No devices present on the wire.\n");
 			break;
 		}

I would even just replace it with dev_dbg(),
since default 10 seconds timeout is more than printk_ratelimit_jiffies. I will add such a patch into w1 queue.

Thank you.

Signature · 1 line
	Evgeniy Polyakov