Skip to contentSkip to conversation

Fix IXP4xx flash resource range

PATCH New Deepak Saxena 1 participant 1 message Aug 24, 2005

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/Intel IXP4XX Arm architecture
lore
Share & tools
lore

Deepak Saxena

author
#0 lore raw

PATCH 1/1 Fix IXP4xx flash resource range

[Resend...forgot to send to lkml]

We are currently reserving one byte more than actually needed by the flash device and overlapping into the next I/O expansion bus window. This a) causes us to allocate an extra page of VM due to ARM ioremap() alignment code and b) could cause problems if another driver tries to request the next expansion bus window.

Signed-off-by Deepak Saxena <[email protected]>
arch/arm/mach-ixp4xx/coyote-setup.c +1 -1
@@ -36,7 +36,7 @@ static struct flash_platform_data coyote
 
 static struct resource coyote_flash_resource = {
 	.start		= COYOTE_FLASH_BASE,
-	.end		= COYOTE_FLASH_BASE + COYOTE_FLASH_SIZE,
+	.end		= COYOTE_FLASH_BASE + COYOTE_FLASH_SIZE - 1,
 	.flags		= IORESOURCE_MEM,
 };
arch/arm/mach-ixp4xx/gtwx5715-setup.c +1 -1
@@ -114,7 +114,7 @@ static struct flash_platform_data gtwx57
 
 static struct resource gtwx5715_flash_resource = {
 	.start		= GTWX5715_FLASH_BASE,
-	.end		= GTWX5715_FLASH_BASE + GTWX5715_FLASH_SIZE,
+	.end		= GTWX5715_FLASH_BASE + GTWX5715_FLASH_SIZE - 1,
 	.flags		= IORESOURCE_MEM,
 };
arch/arm/mach-ixp4xx/ixdp425-setup.c +1 -1
@@ -36,7 +36,7 @@ static struct flash_platform_data ixdp42
 
 static struct resource ixdp425_flash_resource = {
 	.start		= IXDP425_FLASH_BASE,
-	.end		= IXDP425_FLASH_BASE + IXDP425_FLASH_SIZE,
+	.end		= IXDP425_FLASH_BASE + IXDP425_FLASH_SIZE - 1,
 	.flags		= IORESOURCE_MEM,
 };
Signature · 3 lines
Deepak Saxena - [email protected] - http://www.plexity.net

Even a stopped clock gives the right time twice a day.