Skip to contentSkip to conversation

x86_64: Choose physflat for AMD systems only when >8 CPUS.

PATCH Ashok Raj 1 participant 1 message Sep 6, 2005 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

Ashok Raj

author
#2 lore raw
Quoted 9 lines · Andi Kleen
Quoted 6 lines · On Sat, Sep 03, 2005 at 02:33:30PM -0700, [email protected] wrote:

From: Ashok Raj <[email protected]>

It is not required to choose the physflat mode when CPU hotplug is enabled and CPUs <=8 case. Use of genapic_flat with the mask version is capable of doing the same, instead of doing the send_IPI_mask_sequence() where its a unicast.

I don't get the reasoning of this change. So probably not.

Hummm...Please see below. Nothing has changed since then, any idea why its not acceptable now?

http://marc.theaimsgroup.com/?l=linux-kernel&m=112315304423377&w=2

This really doesnt affect me, it just bothers me to go over inefficient code. send_IPI_mask_sequence() does unicast IPI's. When number of CPUs is <=8 the mask version acheives the same with just one write, so its a selective broadcast which is more efficient.

Based on our earlier exchange i assumed it was clear and apparent which is why you "OK"ed the version when it was submitted to -mm.

Nothing has changed, its the exact same patch. Hope its clear now.

Entirely up to you... :-(

Signature · 3 lines
Cheers,
Ashok Raj
- Open Source Technology Center