Skip to contentSkip to conversation

Brand-new notebook useless with Linux...

DISCUSSION Applied Chuck Ebbert 3 participants 4 messages Sep 9, 2005 – Sep 12, 2005 Sound

lore
Share & tools
lore
#0 lore raw

In-Reply-To: <1126207905.12697.20.camel@mindpipe>

Quoted 6 lines · Lee Revell

Wait, that sounds like the modem, not the AC97 audio codec.

You might be able to get the modem to work with the (proprietary) slmodem software modem, or something. I wouldn't count on it though.

Does your sound work?

Well I'll be...

I'd assumed from the (confusing) messages that the sound card was
not working, but it seems fine. Shouldn't the error messages from atiixp-modem be prefixed with that name instead of "atiixp"?

Untested patch follows.

 sound/pci/atiixp_modem.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)
sound/pci/atiixp_modem.c +8 -8
@@ -405,7 +405,7 @@ static int snd_atiixp_acquire_codec(atii
 
 	while (atiixp_read(chip, PHYS_OUT_ADDR) & ATI_REG_PHYS_OUT_ADDR_EN) {
 		if (! timeout--) {
-			snd_printk(KERN_WARNING "atiixp: codec acquire timeout\n");
+			snd_printk(KERN_WARNING "atiixp-modem: codec acquire timeout\n");
 			return -EBUSY;
 		}
 		udelay(1);
@@ -436,7 +436,7 @@ static unsigned short snd_atiixp_codec_r
 	} while (--timeout);
 	/* time out may happen during reset */
 	if (reg < 0x7c)
-		snd_printk(KERN_WARNING "atiixp: codec read timeout (reg %x)\n", reg);
+		snd_printk(KERN_WARNING "atiixp-modem: codec read timeout (reg %x)\n", reg);
 	return 0xffff;
 }
 
@@ -498,7 +498,7 @@ static int snd_atiixp_aclink_reset(atiix
 		do_delay();
 		atiixp_update(chip, CMD, ATI_REG_CMD_AC_RESET, ATI_REG_CMD_AC_RESET);
 		if (--timeout) {
-			snd_printk(KERN_ERR "atiixp: codec reset timeout\n");
+			snd_printk(KERN_ERR "atiixp-modem: codec reset timeout\n");
 			break;
 		}
 	}
@@ -552,7 +552,7 @@ static int snd_atiixp_codec_detect(atiix
 	atiixp_write(chip, IER, 0); /* disable irqs */
 
 	if ((chip->codec_not_ready_bits & ALL_CODEC_NOT_READY) == ALL_CODEC_NOT_READY) {
-		snd_printk(KERN_ERR "atiixp: no codec detected!\n");
+		snd_printk(KERN_ERR "atiixp-modem: no codec detected!\n");
 		return -ENXIO;
 	}
 	return 0;
@@ -635,7 +635,7 @@ static void snd_atiixp_xrun_dma(atiixp_t
 {
 	if (! dma->substream || ! dma->running)
 		return;
-	snd_printdd("atiixp: XRUN detected (DMA %d)\n", dma->ops->type);
+	snd_printdd("atiixp-modem: XRUN detected (DMA %d)\n", dma->ops->type);
 	snd_pcm_stop(dma->substream, SNDRV_PCM_STATE_XRUN);
 }
 
@@ -1081,14 +1081,14 @@ static int __devinit snd_atiixp_mixer_ne
 		ac97.scaps = AC97_SCAP_SKIP_AUDIO;
 		if ((err = snd_ac97_mixer(pbus, &ac97, &chip->ac97[i])) < 0) {
 			chip->ac97[i] = NULL; /* to be sure */
-			snd_printdd("atiixp: codec %d not available for modem\n", i);
+			snd_printdd("atiixp-modem: codec %d not available for modem\n", i);
 			continue;
 		}
 		codec_count++;
 	}
 
 	if (! codec_count) {
-		snd_printk(KERN_ERR "atiixp: no codec available\n");
+		snd_printk(KERN_ERR "atiixp-modem: no codec available\n");
 		return -ENODEV;
 	}
 
@@ -1159,7 +1159,7 @@ static void __devinit snd_atiixp_proc_in
 {
 	snd_info_entry_t *entry;
 
-	if (! snd_card_proc_new(chip->card, "atiixp", &entry))
+	if (! snd_card_proc_new(chip->card, "atiixp-modem", &entry))
 		snd_info_set_text_ops(entry, chip, 1024, snd_atiixp_proc_read);
 }
 

__
Chuck
Subliminal URL: www.sluggy.com/daily.php?date=050905

#1 lore raw
Quoted 14 lines · Chuck Ebbert

In-Reply-To: <1126207905.12697.20.camel@mindpipe>

Quoted 6 lines · Lee Revell

Wait, that sounds like the modem, not the AC97 audio codec.

You might be able to get the modem to work with the (proprietary) slmodem software modem, or something. I wouldn't count on it though.

Does your sound work?

Well I'll be...

Quoted 7 lines

I'd assumed from the (confusing) messages that the sound card was
not working, but it seems fine. Shouldn't the error messages from atiixp-modem be prefixed with that name instead of "atiixp"?

Untested patch follows.

This should be applied IMO. Can we get it in CVS?

Lee

-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

Applied
#2 lore raw

At Sun, 11 Sep 2005 21:42:44 -0400,

Quoted 20 lines · Lee Revell
Quoted 18 lines · Chuck Ebbert

In-Reply-To: <1126207905.12697.20.camel@mindpipe>

Quoted 6 lines · Lee Revell

Wait, that sounds like the modem, not the AC97 audio codec.

You might be able to get the modem to work with the (proprietary) slmodem software modem, or something. I wouldn't count on it though.

Does your sound work?

Well I'll be...

I'd assumed from the (confusing) messages that the sound card was
not working, but it seems fine. Shouldn't the error messages from atiixp-modem be prefixed with that name instead of "atiixp"?

Quoted 5 lines
Quoted 3 lines

Untested patch follows.

This should be applied IMO. Can we get it in CVS?

Applied to CVS now. Thanks!

Takashi

Applied
#3 lore raw
In reply to Lee Revell

At Sun, 11 Sep 2005 21:42:44 -0400,

Quoted 20 lines · Lee Revell
Quoted 18 lines · Chuck Ebbert

In-Reply-To: <1126207905.12697.20.camel@mindpipe>

Quoted 6 lines · Lee Revell

Wait, that sounds like the modem, not the AC97 audio codec.

You might be able to get the modem to work with the (proprietary) slmodem software modem, or something. I wouldn't count on it though.

Does your sound work?

Well I'll be...

I'd assumed from the (confusing) messages that the sound card was
not working, but it seems fine. Shouldn't the error messages from atiixp-modem be prefixed with that name instead of "atiixp"?

Quoted 5 lines
Quoted 3 lines

Untested patch follows.

This should be applied IMO. Can we get it in CVS?

Applied to CVS now. Thanks!

Takashi

-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf