Skip to contentSkip to conversation

More PCI patches for 2.6.13

PATCH Gabriel A. Devenyi 1 participant 1 message Sep 11, 2005

lore
Share & tools
lore
#0 lore raw

Hi Andrew,

I noticed your mail about this bug in a discussion on PCI patches for 2.6.13, I emailed the list with some info about this bug, so here it is again, perhaps this can clear up what the problem is, sorry I don't have a patch, I don't understand the kernel well enough for that.

drivers/pci/probe.c: In function `pci_read_bases':
drivers/pci/probe.c:166: warning: large integer implicitly truncated to unsigned type drivers/pci/probe.c:216: warning: large integer implicitly truncated to unsigned type

I've tracked this down to pci_size, and two #define's in include/linux/pci.h

#define PCI_BASE_ADDRESS_MEM_MASK (~0x0fUL)
#define PCI_ROM_ADDRESS_MASK (~0x7ffUL)

pci_size expects 3 u32 arguments,but from what I can tell, on 64 bit arch's the two above defines expand to 64bit values, and are truncated when being passed.

I'm not sure how to go about fixing this, if pci_size should accept a u64 or if the defines should be changed. Is this bug dangerous? What should be done to fix it?

Signature · 2 lines
Gabriel A. Devenyi
[email protected]