Skip to contentSkip to conversation

Fix I2O config-osm init to return proper error

PATCH New Deepak Saxena 1 participant 1 message Sep 20, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix I2O config-osm init to return proper error

We currently unregister the config-osm driver if initialization of the legacy ioctl() handlers failed but still return success. We should be returning -EBUSY in this case.

drivers/message/i2o/config-osm.c +4 -1
@@ -56,8 +56,11 @@ static int __init i2o_config_init(void)
 		return -EBUSY;
 	}
 #ifdef CONFIG_I2O_CONFIG_OLD_IOCTL
-	if (i2o_config_old_init())
+	if (i2o_config_old_init()) {
+		osm_err("old config handler initialization failed\n");
 		i2o_driver_unregister(&i2o_config_driver);
+		return -EBUSY;
+	}
 #endif
 
 	return 0;
Signature · 3 lines
Deepak Saxena - [email protected] - http://www.plexity.net

Even a stopped clock gives the right time twice a day.