Skip to contentSkip to conversation

bogus VIA IRQ fixup in drivers/pci/quirks.c

DISCUSSION Olaf Hering 4 participants 13 messages Sep 26, 2005 – Sep 28, 2005 PCI

lore
Share & tools
lore
#0 lore raw

Why is the irq changed from 24 to 0, and why does uhci use irq 24 anyway? I dont have the /proc/interrupts output from this box, maybe no interrupt is handled for the controller? None of the attached usb devices is recognized with 2.6.13.

0000:00:0e.0 USB Controller: VIA Technologies, Inc. VT82xxxx UHCI USB 1.1 Controller (rev 04) (prog-if 00 [UHCI])
Subsystem: VIA Technologies, Inc. (Wrong ID) USB Controller
Flags: bus master, stepping, medium devsel, latency 32, IRQ 24
I/O ports at f2010040 [size=32]

The Mac has a Bandit PCI host bridge and a Grand Central I/O controller.

Here is the boot.msg stuff about the card:

<6>USB Universal Host Controller Interface driver v2.3 <4>PCI: Enabling device 0000:00:0e.0 (0094 ->0095) <6>PCI:Via IRQ fixup for 0000:00:0e.0, from 24 to 0 <6>uhci_hcd 0000:00:0e.0: UHCI Controller
<6>uhci_hcd 0000:00:0e.0: new USB bus registered, assigned bus number 1 <6>uhci_hcd 0000:00:0e.0: irq 24, io base 0x00010040
<6>hub 1-0:1.0: USB hub found
<6>hun 1-0:1.0: 2 ports detected
<6>Initializing USB Mass Storage driver... <6>usbcore:registered new driver usb-storage
<6>USB Mass Storage support registered

Signature · 2 lines
short story of a lazy sysadmin:
 alias appserv=wotan
#1 lore raw
Quoted 5 lines · Olaf Hering

Why is the irq changed from 24 to 0, and why does uhci use irq 24 anyway? I dont have the /proc/interrupts output from this box, maybe no interrupt is handled for the controller? None of the attached usb devices is recognized with 2.6.13.

Did that USB controller use to work in older kernels?

Quoted 3 lines

<6>USB Universal Host Controller Interface driver v2.3 <4>PCI: Enabling device 0000:00:0e.0 (0094 ->0095) <6>PCI:Via IRQ fixup for 0000:00:0e.0, from 24 to 0

That does seem to be seriously broken.

The old code wouldn't do that IRQ fixup for IO-APIC users, and I think that's correct.

The commit (93cffffa19960464a52f9c78d9a6150270d23785) says:

[PATCH] PCI: do VIA IRQ fixup always, not just in PIC mode

At least some VIA chipsets require the fixup even in IO-APIC mode.

This was found and debugged with the patient assistance of Stian Jordet <[email protected]> on an Asus CUV266-DLS motherboard.

and I've cc'd the guilty parties.

Bjorn: there's no way that "& 15" can be correct. There is no reason to believe that the APIC interrupt number bears any relation to the legacy number or the low four bits.

Others (Mathieu Berard) have reported problems with that patch too, I think we should revert it.

What are the numbers for Stian Jordet? It might make more sense to instead of comparing for ACPI/IO-APIC, just compare the irq against 16. Ie just do

	if (dev->irq > 15)
		return;

in quirk_via_irq(), since if it's not a legacy mode interrupt, we simply don't know what to do. That "&15" is just a total guess, and makes little or no sense at all.

Linus

#2 lore raw
Quoted 10 lines · Linus Torvalds
Quoted 5 lines · Olaf Hering

Why is the irq changed from 24 to 0, and why does uhci use irq 24 anyway? I dont have the /proc/interrupts output from this box, maybe no interrupt is handled for the controller? None of the attached usb devices is recognized with 2.6.13.

Did that USB controller use to work in older kernels?

quirk_via_irqpic worked the same, so I guess no.
I will let him try older kernels, and your suggested change.

Signature · 2 lines
short story of a lazy sysadmin:
 alias appserv=wotan
#3 lore raw
In reply to Linus Torvalds
Quoted 5 lines · Linus Torvalds
Quoted 3 lines

<6>USB Universal Host Controller Interface driver v2.3 <4>PCI: Enabling device 0000:00:0e.0 (0094 ->0095) <6>PCI:Via IRQ fixup for 0000:00:0e.0, from 24 to 0

That does seem to be seriously broken.

On a side note:

echo $((24 & 15))
8

Thats what I get on my Mac, and the card works there. Also forcing the irq to 0 doesnt break it.

Signature · 2 lines
short story of a lazy sysadmin:
 alias appserv=wotan
#4 lore raw
In reply to Linus Torvalds

Sitat Linus Torvalds <[email protected]>:

Quoted 22 lines · Olaf Hering
Quoted 5 lines

Why is the irq changed from 24 to 0, and why does uhci use irq 24 anyway? I dont have the /proc/interrupts output from this box, maybe no interrupt is handled for the controller? None of the attached usb devices is recognized with 2.6.13.

Did that USB controller use to work in older kernels?

Quoted 3 lines

<6>USB Universal Host Controller Interface driver v2.3 <4>PCI: Enabling device 0000:00:0e.0 (0094 ->0095) <6>PCI:Via IRQ fixup for 0000:00:0e.0, from 24 to 0

That does seem to be seriously broken.

The old code wouldn't do that IRQ fixup for IO-APIC users, and I think that's correct.

The commit (93cffffa19960464a52f9c78d9a6150270d23785) says:

Quoted 8 lines

[PATCH] PCI: do VIA IRQ fixup always, not just in PIC mode

At least some VIA chipsets require the fixup even in IO-APIC mode.

This was found and debugged with the patient assistance of Stian Jordet <[email protected]> on an Asus CUV266-DLS motherboard.

and I've cc'd the guilty parties.

First, I've no idea of the reasons behind Bjorn's patch. I've had a longstanding bug which makes network traffic generate interrupts on irq 11 (which is for usb), after 100 000 interrupts, irq 11 is disabled. Which is boring. So after seeing Bjorn using some time fixing VIA-related bugs on LKML, I thought I'd mail him and ask for help.

He wanted me to test 2.6.12-rc2-mm3, which actually disabled irq9 as well at boottime. After some debugging, he made this patch, which made irq 9 work as normal again for me. Please don't back this patch out, without at least re-looking at my system.

That other bug, noone have been able to fix, yet.

Attached is dmesg of 2.6.14-rc2-git3.

Best regards,
Stian

#5 lore raw
Quoted 5 lines · Stian Jordet

He wanted me to test 2.6.12-rc2-mm3, which actually disabled irq9 as well at boottime. After some debugging, he made this patch, which made irq 9 work as normal again for me. Please don't back this patch out, without at least re-looking at my system.

Well, looking at your messages, I bet that the appended patch works for you, since your irq's are all in the legacy range.

It is also conceptually closer to what the code _used_ to be (it used to say "if we have an IO-APIC, don't do this", now it says "if this irq is bound to an IO-APIC, don't do this")

Whether this will matter to Olaf, I don't know, but the old code was definitely just writing random bits for the IO-APIC case afaik.

Linus

---

drivers/pci/quirks.c +4 -1
@@ -546,7 +546,10 @@ static void quirk_via_irq(struct pci_dev
 {
 	u8 irq, new_irq;
 
-	new_irq = dev->irq & 0xf;
+	new_irq = dev->irq;
+	if (!new_irq || new_irq >= 15)
+		return;
+
 	pci_read_config_byte(dev, PCI_INTERRUPT_LINE, &irq);
 	if (new_irq != irq) {
 		printk(KERN_INFO "PCI: Via IRQ fixup for %s, from %d to %d\n",
#6 lore raw

Sitat Linus Torvalds <[email protected]>:

Quoted 6 lines

Well, looking at your messages, I bet that the appended patch works for you, since your irq's are all in the legacy range.

It is also conceptually closer to what the code _used_ to be (it used to say "if we have an IO-APIC, don't do this", now it says "if this irq is bound to an IO-APIC, don't do this")

No dice. My irq's beyond 15 are changed. What used to be 19 became 17, 18 became 16, 17 became 18 and 16 became 19. The others are normal, and while looking at dmesg, the fixup is still happening. While it boots, and at first glance seems to work, it hangs hard when I try to use usb. At least the bluetooth dongle, haven't tried with anything else, but I suppose that'd do the same.

Sorry.

Best regards,
Stian

#7 lore raw
Quoted 6 lines · Stian Jordet

No dice. My irq's beyond 15 are changed. What used to be 19 became 17, 18 became 16, 17 became 18 and 16 became 19. The others are normal, and while looking at dmesg, the fixup is still happening. While it boots, and at first glance seems to work, it hangs hard when I try to use usb. At least the bluetooth dongle, haven't tried with anything else, but I suppose that'd do the same.

Your dmesg you sent only had

	PCI: Via IRQ fixup for 0000:00:11.2, from 9 to 11
	PCI: Via IRQ fixup for 0000:00:11.3, from 9 to 11
	PCI: Via IRQ fixup for 0000:00:11.4, from 9 to 11

for the Via IRQ fixup, so I assumed that you only had regular ones.

No irq's over 15 according to that (and no, it's not because of the
masking: you also had

	ACPI: PCI Interrupt Link [LNKD] enabled at IRQ 11
	ACPI: PCI Interrupt 0000:00:11.2[D] -> Link [LNKD] -> GSI 11 (level, low) -> IRQ 11
	ACPI: PCI Interrupt 0000:00:11.3[D] -> Link [LNKD] -> GSI 11 (level, low) -> IRQ 11
	ACPI: PCI Interrupt 0000:00:11.4[D] -> Link [LNKD] -> GSI 11 (level, low) -> IRQ 11

in there.

So the patch I sent should in fact have made zero difference at all for you. What's up?

Linus

#8 lore raw

Sitat Linus Torvalds <[email protected]>:

Quoted 17 lines

Your dmesg you sent only had

	PCI: Via IRQ fixup for 0000:00:11.2, from 9 to 11
	PCI: Via IRQ fixup for 0000:00:11.3, from 9 to 11
	PCI: Via IRQ fixup for 0000:00:11.4, from 9 to 11

for the Via IRQ fixup, so I assumed that you only had regular ones.

No irq's over 15 according to that (and no, it's not because of the
masking: you also had

	ACPI: PCI Interrupt Link [LNKD] enabled at IRQ 11
	ACPI: PCI Interrupt 0000:00:11.2[D] -> Link [LNKD] -> GSI 11 (level, low) ->
IRQ 11
	ACPI: PCI Interrupt 0000:00:11.3[D] -> Link [LNKD] -> GSI 11 (level, low) ->
IRQ 11
	ACPI: PCI Interrupt 0000:00:11.4[D] -> Link [LNKD] -> GSI 11 (level, low) ->
Quoted 6 lines

IRQ 11

in there.

So the patch I sent should in fact have made zero difference at all for you. What's up?

I have no idea. But I'll attach dmesg from the same kernel with your patch, so you'll see the differences yourself. I also see that initialization of everything have changed. Now scsi is almost the last thing in the dmesg, it used to be about the first. Weird.

-Stian

Linux version 2.6.14-rc2-git3 (root@chevrolet) (gcc version 4.0.2 20050808 (prerelease) (Ubuntu 4.0.1-4ubuntu8)) #5 SMP Tue Sep 27 16:50:55 CEST 2005 BIOS-provided physical RAM map:
BIOS-e820: 0000000000000000 - 000000000009f800 (usable)
BIOS-e820: 000000000009f800 - 00000000000a0000 (reserved)
BIOS-e820: 00000000000f0000 - 0000000000100000 (reserved)
BIOS-e820: 0000000000100000 - 000000001fffc000 (usable)
BIOS-e820: 000000001fffc000 - 000000001ffff000 (ACPI data)
BIOS-e820: 000000001ffff000 - 0000000020000000 (ACPI NVS)
BIOS-e820: 00000000fec00000 - 00000000fec01000 (reserved)
BIOS-e820: 00000000fee00000 - 00000000fee01000 (reserved)
BIOS-e820: 00000000ffff0000 - 0000000100000000 (reserved)
511MB LOWMEM available.
found SMP MP-table at 000f5500
On node 0 totalpages: 131068
DMA zone: 4096 pages, LIFO batch:1
Normal zone: 126972 pages, LIFO batch:31
HighMem zone: 0 pages, LIFO batch:1
DMI 2.3 present.
ACPI: RSDP (v000 ASUS ) @ 0x000f6930
ACPI: RSDT (v001 ASUS CV266DLS 0x30303031 MSFT 0x31313031) @ 0x1fffc000
ACPI: FADT (v001 ASUS CV266DLS 0x30303031 MSFT 0x31313031) @ 0x1fffc100
ACPI: BOOT (v001 ASUS CV266DLS 0x30303031 MSFT 0x31313031) @ 0x1fffc040
ACPI: MADT (v001 ASUS CV266DLS 0x30303031 MSFT 0x31313031) @ 0x1fffc080
ACPI: DSDT (v001 ASUS CV266DLS 0x00001000 MSFT 0x0100000b) @ 0x00000000
ACPI: PM-Timer IO Port: 0xe408
ACPI: Local APIC address 0xfee00000
ACPI: LAPIC (acpi_id[0x00] lapic_id[0x03] enabled)
Processor #3 6:8 APIC version 17
ACPI: LAPIC (acpi_id[0x01] lapic_id[0x00] enabled)
Processor #0 6:8 APIC version 17
ACPI: IOAPIC (id[0x02] address[0xfec00000] gsi_base[0])
IOAPIC[0]: apic_id 2, version 17, address 0xfec00000, GSI 0-23
ACPI: INT_SRC_OVR (bus 0 bus_irq 0 global_irq 2 dfl edge)
ACPI: INT_SRC_OVR (bus 0 bus_irq 9 global_irq 9 low level)
ACPI: IRQ0 used by override.
ACPI: IRQ2 used by override.
ACPI: IRQ9 used by override.
Enabling APIC mode: Flat. Using 1 I/O APICs
Using ACPI (MADT) for SMP configuration information
Allocating PCI resources starting at 30000000 (gap: 20000000:dec00000)
Built 1 zonelists
Kernel command line: root=/dev/sda2 ro noirqdebug quiet splash
IRQ lockup detection disabled
mapped APIC to ffffd000 (fee00000)
mapped IOAPIC to ffffc000 (fec00000)
Initializing CPU#0
PID hash table entries: 2048 (order: 11, 32768 bytes)
Detected 999.804 MHz processor.
Using pmtmr for high-res timesource
Console: colour VGA+ 80x25
Dentry cache hash table entries: 131072 (order: 7, 524288 bytes)
Inode-cache hash table entries: 65536 (order: 6, 262144 bytes)
Memory: 513000k/524272k available (4100k kernel code, 10736k reserved, 1168k data, 240k init, 0k highmem)
Checking if this processor honours the WP bit even in supervisor mode... Ok.
Calibrating delay using timer specific routine.. 2002.14 BogoMIPS (lpj=4004293)
Mount-cache hash table entries: 512
CPU: After generic identify, caps: 0383fbff 00000000 00000000 00000000 00000000 00000000 00000000
CPU: After vendor identify, caps: 0383fbff 00000000 00000000 00000000 00000000 00000000 00000000
CPU: L1 I cache: 16K, L1 D cache: 16K
CPU: L2 cache: 256K
CPU: After all inits, caps: 0383fbff 00000000 00000000 00000040 00000000 00000000 00000000
Intel machine check architecture supported.
Intel machine check reporting enabled on CPU#0.
mtrr: v2.0 (20020519)
Enabling fast FPU save and restore... done.
Enabling unmasked SIMD FPU exception support... done.
Checking 'hlt' instruction... OK.
CPU0: Intel Pentium III (Coppermine) stepping 0a
Booting processor 1/0 eip 2000
Initializing CPU#1
Calibrating delay using timer specific routine.. 1999.61 BogoMIPS (lpj=3999227)
CPU: After generic identify, caps: 0383fbff 00000000 00000000 00000000 00000000 00000000 00000000
CPU: After vendor identify, caps: 0383fbff 00000000 00000000 00000000 00000000 00000000 00000000
CPU: L1 I cache: 16K, L1 D cache: 16K
CPU: L2 cache: 256K
CPU: After all inits, caps: 0383fbff 00000000 00000000 00000040 00000000 00000000 00000000
Intel machine check architecture supported.
Intel machine check reporting enabled on CPU#1.
CPU1: Intel Pentium III (Coppermine) stepping 0a
Total of 2 processors activated (4001.76 BogoMIPS).
ENABLING IO-APIC IRQs
..TIMER: vector=0x31 pin1=2 pin2=-1
checking TSC synchronization across 2 CPUs: passed.
Brought up 2 CPUs
NET: Registered protocol family 16
ACPI: bus type pci registered
PCI: PCI BIOS revision 2.10 entry at 0xf0d40, last bus=1
PCI: Using configuration type 1
ACPI: Subsystem revision 20050902
ACPI: Interpreter enabled
ACPI: Using IOAPIC for interrupt routing
ACPI: PCI Interrupt Link [LNKA] (IRQs 3 4 5 6 7 9 10 *11 12 14 15)
ACPI: PCI Interrupt Link [LNKB] (IRQs 3 4 5 6 7 9 *10 11 12 14 15)
ACPI: PCI Interrupt Link [LNKC] (IRQs 3 4 *5 6 7 9 10 11 12 14 15)
ACPI: PCI Interrupt Link [LNKD] (IRQs 3 4 5 6 7 *9 10 11 12 14 15)
ACPI: PCI Root Bridge [PCI0] (0000:00)
PCI: Probing PCI hardware (bus 00)
ACPI: Assume root bridge [\_SB_.PCI0] bus is 0
Boot video device is 0000:01:00.0
ACPI: PCI Interrupt Routing Table [\_SB_.PCI0._PRT]
ACPI: PCI Interrupt Routing Table [\_SB_.PCI0.PCI1._PRT]
SCSI subsystem initialized
usbcore: registered new driver usbfs
usbcore: registered new driver hub
PCI: Using ACPI for IRQ routing
PCI: If a device doesn't work, try "pci=routeirq". If it helps, post a report
irda_init()
NET: Registered protocol family 23
Bluetooth: Core ver 2.7
NET: Registered protocol family 31
Bluetooth: HCI device and connection manager initialized
Bluetooth: HCI socket layer initialized
PCI: Bridge: 0000:00:01.0
IO window: d000-dfff
MEM window: de800000-dfdfffff
PREFETCH window: e0000000-f7ffffff
PCI: Bus 2, cardbus bridge: 0000:00:0f.0
IO window: 00001000-00001fff
IO window: 00002000-00002fff
PREFETCH window: 30000000-31ffffff
MEM window: 32000000-33ffffff
PCI: Bus 6, cardbus bridge: 0000:00:0f.1
IO window: 00003000-00003fff
IO window: 00004000-00004fff
PREFETCH window: 34000000-35ffffff
MEM window: 36000000-37ffffff
PCI: Setting latency timer of device 0000:00:01.0 to 64
PCI: Enabling device 0000:00:0f.0 (0000 -> 0003)
ACPI: PCI Interrupt 0000:00:0f.0[A] -> GSI 18 (level, low) -> IRQ 16
PCI: Enabling device 0000:00:0f.1 (0000 -> 0003)
ACPI: PCI Interrupt 0000:00:0f.1[B] -> GSI 19 (level, low) -> IRQ 17
Simple Boot Flag at 0x3a set to 0x1
IA-32 Microcode Update Driver: v1.14 <[email protected]>
NTFS driver 2.1.24 [Flags: R/O].
SGI XFS with ACLs, no debug enabled
SGI XFS Quota Management subsystem
ACPI: Power Button (FF) [PWRF]
ACPI: Power Button (CM) [PWRB]
ACPI: CPU0 (power states: C1[C1])
ACPI: CPU1 (power states: C1[C1])
Real Time Clock Driver v1.12
Linux agpgart interface v0.101 (c) Dave Jones
agpgart: Detected VIA Pro 266 chipset
agpgart: AGP aperture is 64M @ 0xf8000000
serio: i8042 AUX port at 0x60,0x64 irq 12
serio: i8042 KBD port at 0x60,0x64 irq 1
Serial: 8250/16550 driver $Revision: 1.90 $ 4 ports, IRQ sharing disabled
ttyS0 at I/O 0x3f8 (irq = 4) is a 16550A
ttyS1 at I/O 0x2f8 (irq = 3) is a 16550A
io scheduler noop registered
io scheduler anticipatory registered
io scheduler deadline registered
io scheduler cfq registered
Floppy drive(s): fd0 is 1.44M
FDC 0 is a post-1991 82077
loop: loaded (max 8 devices)
pktcdvd: v0.2.0a 2004-07-14 Jens Axboe ([email protected]) and [email protected]
e100: Intel(R) PRO/100 Network Driver, 3.4.14-k2-NAPI
e100: Copyright(c) 1999-2005 Intel Corporation
ACPI: PCI Interrupt 0000:00:05.0[A] -> GSI 19 (level, low) -> IRQ 17
e100: eth0: e100_probe: addr 0xde000000, irq 17, MAC addr 00:E0:18:2E:FF:C0
PPP generic driver version 2.4.2
PPP Deflate Compression module registered
PPP BSD Compression module registered
netconsole: not configured, aborting
Linux video capture interface: v1.00
saa7130/34: v4l2 driver version 0.2.14 loaded
ACPI: PCI Interrupt 0000:00:0c.0[A] -> GSI 19 (level, low) -> IRQ 17
saa7134[0]: found at 0000:00:0c.0, rev: 1, irq: 17, latency: 32, mmio: 0xdc000000
saa7134[0]: subsystem: 153b:1143, board: Terratec Cinergy 600 TV [card=11,autodetected]
saa7134[0]: board init: gpio is 50000
saa7134[0]: registered input device for IR
saa7134[0]: i2c eeprom 00: 3b 15 43 11 ff ff ff ff ff ff ff ff ff ff ff ff
saa7134[0]: i2c eeprom 10: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
saa7134[0]: i2c eeprom 20: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
saa7134[0]: i2c eeprom 30: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
saa7134[0]: registered device video0 [v4l2]
saa7134[0]: registered device vbi0
saa7134[0]: registered device radio0
tuner 0-0060: chip found @ 0xc0 (saa7134[0])
tuner 0-0060: All bytes are equal. It is not a TEA5767
tuner 0-0060: type set to 5 (Philips PAL_BG (FI1216 and compatibles))
Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2
ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx
VP_IDE: IDE controller at PCI slot 0000:00:11.1
VP_IDE: chipset revision 6
VP_IDE: not 100% native mode: will probe irqs later
VP_IDE: VIA vt8233 (rev 00) IDE UDMA100 controller on pci0000:00:11.1

    ide0: BM-DMA at 0xa000-0xa007, BIOS settings: hda:DMA, hdb:DMA
    ide1: BM-DMA at 0xa008-0xa00f, BIOS settings: hdc:pio, hdd:DMA

Probing IDE interface ide0...
hda: ST3200822A, ATA DISK drive
hdb: ST3200822A, ATA DISK drive
ide0 at 0x1f0-0x1f7,0x3f6 on irq 14
Probing IDE interface ide1...
hdd: IOMEGA ZIP 100 ATAPI Floppy, ATAPI FLOPPY drive
ide1 at 0x170-0x177,0x376 on irq 15
hda: max request size: 1024KiB
hda: 390721968 sectors (200049 MB) w/8192KiB Cache, CHS=24321/255/63, UDMA(33)
hda: cache flushes supported
hda: hda1
hdb: max request size: 1024KiB
hdb: 390721968 sectors (200049 MB) w/8192KiB Cache, CHS=24321/255/63, UDMA(33)
hdb: cache flushes supported
hdb: hdb1
ide-floppy driver 0.99.newide
hdd: No disk in drive
hdd: 98304kB, 96/64/32 CHS, 4096 kBps, 512 sector size, 2941 rpm
ACPI: PCI Interrupt 0000:00:07.0[A] -> GSI 17 (level, low) -> IRQ 18 scsi0 : Adaptec AIC7XXX EISA/VLB/PCI SCSI HBA DRIVER, Rev 7.0
<Adaptec aic7899 Ultra160 SCSI adapter>
aic7899: Ultra160 Wide Channel A, SCSI Id=7, 32/253 SCBs

Vendor: SEAGATE Model: ST318452LW Rev: 0004
Type: Direct-Access ANSI SCSI revision: 03
scsi0:A:0:0: Tagged Queuing enabled. Depth 253
target0:0:0: Beginning Domain Validation
target0:0:0: wide asynchronous.
target0:0:0: FAST-80 WIDE SCSI 160.0 MB/s DT (12.5 ns, offset 63) target0:0:0: Ending Domain Validation
ACPI: PCI Interrupt 0000:00:07.1[B] -> GSI 18 (level, low) -> IRQ 16 scsi1 : Adaptec AIC7XXX EISA/VLB/PCI SCSI HBA DRIVER, Rev 7.0
<Adaptec aic7899 Ultra160 SCSI adapter>
aic7899: Ultra160 Wide Channel B, SCSI Id=7, 32/253 SCBs

Vendor: PIONEER Model: DVD-ROM DVD-304F Rev: 1.03
Type: CD-ROM ANSI SCSI revision: 02
target1:0:4: Beginning Domain Validation
target1:0:4: Domain Validation skipping write tests
target1:0:4: FAST-20 SCSI 20.0 MB/s ST (50 ns, offset 16) target1:0:4: Ending Domain Validation
Vendor: YAMAHA Model: CRW-F1S Rev: 1.0g
Type: CD-ROM ANSI SCSI revision: 02
target1:0:5: Beginning Domain Validation
target1:0:5: Domain Validation skipping write tests
target1:0:5: FAST-20 SCSI 20.0 MB/s ST (50 ns, offset 15) target1:0:5: Ending Domain Validation
Vendor: SEAGATE Model: DAT 04687-XXX Rev: 6610
Type: Sequential-Access ANSI SCSI revision: 02
target1:0:6: Beginning Domain Validation
target1:0:6: Domain Validation skipping write tests
target1:0:6: FAST-10 SCSI 7.8 MB/s ST (128 ns, offset 15) target1:0:6: Ending Domain Validation
st: Version 20050830, fixed bufsize 32768, s/g segs 256
Attached scsi tape st0 at scsi1, channel 0, id 6, lun 0
st0: try direct i/o: yes (alignment 512 B), max page reachable by HBA 1048575 SCSI device sda: 35843670 512-byte hdwr sectors (18352 MB)
SCSI device sda: drive cache: write back
SCSI device sda: 35843670 512-byte hdwr sectors (18352 MB)
SCSI device sda: drive cache: write back
sda: sda1 sda2 sda3 sda4
Attached scsi disk sda at scsi0, channel 0, id 0, lun 0
sr0: scsi3-mmc drive: 0x/0x cd/rw xa/form2 cdda tray
Uniform CD-ROM driver Revision: 3.20
Attached scsi CD-ROM sr0 at scsi1, channel 0, id 4, lun 0
sr1: scsi3-mmc drive: 44x/44x writer cd/rw xa/form2 cdda tray Attached scsi CD-ROM sr1 at scsi1, channel 0, id 5, lun 0

Attached scsi generic sg0 at scsi0, channel 0, id 0, lun 0,  type 0
Attached scsi generic sg1 at scsi1, channel 0, id 4, lun 0,  type 5
Attached scsi generic sg2 at scsi1, channel 0, id 5, lun 0,  type 5
Attached scsi generic sg3 at scsi1, channel 0, id 6, lun 0,  type 1

ACPI: PCI Interrupt 0000:00:0f.0[A] -> GSI 18 (level, low) -> IRQ 16
Yenta: CardBus bridge found at 0000:00:0f.0 [14ef:0220]
Yenta: ISA IRQ mask 0x0000, PCI irq 16
Socket status: 30000006
ACPI: PCI Interrupt 0000:00:0f.1[B] -> GSI 19 (level, low) -> IRQ 17
Yenta: CardBus bridge found at 0000:00:0f.1 [14ef:0220]
Yenta: ISA IRQ mask 0x0000, PCI irq 17
Socket status: 30000006
usbmon: debugfs is not available
USB Universal Host Controller Interface driver v2.3
ACPI: PCI Interrupt Link [LNKD] enabled at IRQ 11
ACPI: PCI Interrupt 0000:00:11.2[D] -> Link [LNKD] -> GSI 11 (level, low) -> IRQ 11
PCI: Via IRQ fixup for 0000:00:11.2, from 9 to 11
uhci_hcd 0000:00:11.2: UHCI Host Controller
uhci_hcd 0000:00:11.2: new USB bus registered, assigned bus number 1
uhci_hcd 0000:00:11.2: irq 11, io base 0x00009800
hub 1-0:1.0: USB hub found
hub 1-0:1.0: 2 ports detected
ACPI: PCI Interrupt 0000:00:11.3[D] -> Link [LNKD] -> GSI 11 (level, low) -> IRQ 11
PCI: Via IRQ fixup for 0000:00:11.3, from 9 to 11
uhci_hcd 0000:00:11.3: UHCI Host Controller
uhci_hcd 0000:00:11.3: new USB bus registered, assigned bus number 2
uhci_hcd 0000:00:11.3: irq 11, io base 0x00009400
hub 2-0:1.0: USB hub found
hub 2-0:1.0: 2 ports detected
ACPI: PCI Interrupt 0000:00:11.4[D] -> Link [LNKD] -> GSI 11 (level, low) -> IRQ 11
PCI: Via IRQ fixup for 0000:00:11.4, from 9 to 11
uhci_hcd 0000:00:11.4: UHCI Host Controller
uhci_hcd 0000:00:11.4: new USB bus registered, assigned bus number 3
uhci_hcd 0000:00:11.4: irq 11, io base 0x00009000
hub 3-0:1.0: USB hub found
hub 3-0:1.0: 2 ports detected
usbcore: registered new driver usblp
drivers/usb/class/usblp.c: v0.13: USB Printer Device Class driver
Initializing USB Mass Storage driver...
usbcore: registered new driver usb-storage
USB Mass Storage support registered.
usb 2-1: new full speed USB device using uhci_hcd and address 2
usbcore: registered new driver hiddev
usbcore: registered new driver usbhid
drivers/usb/input/hid-core.c: v2.6:USB HID core driver
usbcore: registered new driver usbserial
drivers/usb/serial/usb-serial.c: USB Serial Driver core v2.0 drivers/usb/serial/usb-serial.c: USB Serial support registered for FTDI USB Serial Device
usbcore: registered new driver ftdi_sio
drivers/usb/serial/ftdi_sio.c: v1.4.3:USB FTDI Serial Converters Driver
mice: PS/2 mouse device common for all mice
input: PC Speaker
gameport: EMU10K1 is pci0000:00:0e.1/gameport0, io 0xa400, speed 1193kHz
input: AT Translated Set 2 keyboard on isa0060/serio0
logips2pp: Detected unknown logitech mouse model 57
Bluetooth: HCI USB driver ver 2.9
usbcore: registered new driver hci_usb
ISDN subsystem Rev: 1.1.2.3/1.1.2.3/1.1.2.2/1.1.2.3/none/1.1.2.2
PPP BSD Compression module registered
HiSax: Linux Driver for passive ISDN cards
HiSax: Version 3.5 (kernel)
HiSax: Layer1 Revision 2.46.2.5
HiSax: Layer2 Revision 2.30.2.4
HiSax: TeiMgr Revision 2.20.2.3
HiSax: Layer3 Revision 2.22.2.3
HiSax: LinkLayer Revision 2.59.2.4
HiSax: Total 1 card defined
HiSax: Card 1 Protocol EDSS1 Id=HiSax (0)
HiSax: Teles/PCI driver Rev. 2.23.2.3
ACPI: PCI Interrupt 0000:00:0d.0[A] -> GSI 16 (level, low) -> IRQ 19
Found: Zoran, base-address: 0xdb800000, irq: 0x13
HiSax: Teles PCI config irq:19 mem:e084e000
TelesPCI: ISAC version (0): 2086/2186 V1.1
TelesPCI: HSCX version A: V2.1 B: V2.1
Teles PCI: IRQ 19 count 0
input: ImExPS/2 Logitech Explorer Mouse on isa0060/serio1
Teles PCI: IRQ 19 count 3
HiSax: DSS1 Rev. 2.32.2.3
HiSax: 2 channels added
HiSax: MAX_WAITING_CALLS added
Advanced Linux Sound Architecture Driver Version 1.0.10rc1 (Mon Sep 12 08:13:09 2005 UTC). specify port
ACPI: PCI Interrupt 0000:00:0e.0[A] -> GSI 17 (level, low) -> IRQ 18
ALSA device list:
#0: SBLive! Platinum 5.1 [SB0060] (rev.7, serial:0x80611102) at 0xa800, irq 18
NET: Registered protocol family 2
IP route cache hash table entries: 8192 (order: 3, 32768 bytes)
TCP established hash table entries: 32768 (order: 6, 262144 bytes)
TCP bind hash table entries: 32768 (order: 6, 262144 bytes)
TCP: Hash tables configured (established 32768 bind 32768)
TCP reno registered
ip_conntrack version 2.3 (4095 buckets, 32760 max) - 256 bytes per conntrack
ip_tables: (C) 2000-2002 Netfilter core team
ipt_recent v0.3.1: Stephen Frost <[email protected]>. http://snowman.net/projects/ipt_recent/
ClusterIP Version 0.8 loaded successfully
arp_tables: (C) 2002 David S. Miller
TCP bic registered
NET: Registered protocol family 1
NET: Registered protocol family 17
IrCOMM protocol (Dag Brattli)
Bluetooth: L2CAP ver 2.7
Bluetooth: L2CAP socket layer initialized
Bluetooth: RFCOMM ver 1.5
Bluetooth: RFCOMM socket layer initialized
Bluetooth: RFCOMM TTY layer initialized
Bluetooth: BNEP (Ethernet Emulation) ver 1.2
Bluetooth: BNEP filters: protocol multicast
Using IPI Shortcut mode
kjournald starting. Commit interval 5 seconds
EXT3-fs: mounted filesystem with ordered data mode.
VFS: Mounted root (ext3 filesystem) readonly.
Freeing unused kernel memory: 240k freed
Adding 1052248k swap on /dev/sda4. Priority:-1 extents:1 across:1052248k
EXT3 (no)user_xattr options not supported
EXT3 FS on sda2, internal journal
cdrom: failed setting lba address space
XFS mounting filesystem sda3
Ending clean XFS mount for filesystem: sda3
XFS mounting filesystem hda1
Ending clean XFS mount for filesystem: hda1
XFS mounting filesystem hdb1
Ending clean XFS mount for filesystem: hdb1
NTFS volume version 3.1.
e100: eth0: e100_watchdog: link up, 100Mbps, full-duplex

#12 lore raw
In reply to Linus Torvalds

Sitat Linus Torvalds <[email protected]>:

Quoted 14 lines · Stian Jordet
Quoted 2 lines

No dice. My irq's beyond 15 are changed. What used to be 19 became 17, 18

became

Quoted 1 line

16, 17 became 18 and 16 became 19. The others are normal, and while looking

at

Quoted 1 line

dmesg, the fixup is still happening. While it boots, and at first glance

seems

Quoted 1 line

to work, it hangs hard when I try to use usb. At least the bluetooth

dongle,

Quoted 1 line

haven't tried with anything else, but I suppose that'd do the same.

Sorry! I was looking at the wrong dmesg. *stupid*. Really sorry about that. It still hangs hard when I try to use usb, but I'll double check that it worked before the patch before I complain more :P

Once again, sorry. And thank you :)

-Stian

#9 lore raw
In reply to Stian Jordet
Quoted 5 lines · Stian Jordet

I have no idea. But I'll attach dmesg from the same kernel with your patch, so you'll see the differences yourself. I also see that initialization of everything have changed. Now scsi is almost the last thing in the dmesg, it used to be about the first. Weird.

That's not my patch. Something else has changed.

Anyway, this dmesg you posted still says

	...
	USB Universal Host Controller Interface driver v2.3
	ACPI: PCI Interrupt Link [LNKD] enabled at IRQ 11
	ACPI: PCI Interrupt 0000:00:11.2[D] -> Link [LNKD] -> GSI 11 (level, low) -> IRQ 11
**	PCI: Via IRQ fixup for 0000:00:11.2, from 9 to 11
	uhci_hcd 0000:00:11.2: UHCI Host Controller
	uhci_hcd 0000:00:11.2: new USB bus registered, assigned bus number 1
	uhci_hcd 0000:00:11.2: irq 11, io base 0x00009800
	hub 1-0:1.0: USB hub found
	hub 1-0:1.0: 2 ports detected
	ACPI: PCI Interrupt 0000:00:11.3[D] -> Link [LNKD] -> GSI 11 (level, low) -> IRQ 11
**	PCI: Via IRQ fixup for 0000:00:11.3, from 9 to 11
	uhci_hcd 0000:00:11.3: UHCI Host Controller
	uhci_hcd 0000:00:11.3: new USB bus registered, assigned bus number 2
	uhci_hcd 0000:00:11.3: irq 11, io base 0x00009400
	hub 2-0:1.0: USB hub found
	hub 2-0:1.0: 2 ports detected
	ACPI: PCI Interrupt 0000:00:11.4[D] -> Link [LNKD] -> GSI 11 (level, low) -> IRQ 11
**	PCI: Via IRQ fixup for 0000:00:11.4, from 9 to 11
	...

so my patch didn't change anything at all for you (which is correct - it was designed not to ;)

So if you have trouble with it, it's something else.

Linus

#10 lore raw

Hi Linus,

Le Tue, 27 Sep 2005 15:58:33 -0700, Linus Torvalds a écrit :

Quoted 6 lines

so my patch didn't change anything at all for you (which is correct - it was designed not to ;)

It will for me as I have [1].

But since the irq for ide are probe after, I think it won't change anything.
I will try your patch when I'll have some free time.

Matthieu

PS : The Via fix are quite strange, as if I understand the message it try to map usb to irq 1...

[1]
$dmesg | grep -B2 -A2 "Via IRQ"
VP_IDE: IDE controller at PCI slot 0000:00:11.1
ACPI: PCI Interrupt 0000:00:11.1[A]: no GSI
PCI: Via IRQ fixup for 0000:00:11.1, from 255 to 15
VP_IDE: chipset revision 6
VP_IDE: not 100% native mode: will probe irqs later
VP_IDE: VIA vt8235 (rev 00) IDE UDMA133 controller on pci0000:00:11.1

    ide0: BM-DMA at 0xfc00-0xfc07, BIOS settings: hda:DMA, hdb:DMA
    ide1: BM-DMA at 0xfc08-0xfc0f, BIOS settings: hdc:DMA, hdd:DMA

Probing IDE interface ide0...
hda: SAMSUNG SP0802N, ATA DISK drive
hdb: IC35L040AVVA07-0, ATA DISK drive
ide0 at 0x1f0-0x1f7,0x3f6 on irq 14
Probing IDE interface ide1...
hdc: TOSHIBA DVD-ROM SD-M1612, ATAPI CD/DVD-ROM drive
hdd: CD-RW CDR-6S48, ATAPI CD/DVD-ROM drive
ide1 at 0x170-0x177,0x376 on irq 15
--
usbmon: debugfs is not available
ACPI: PCI Interrupt 0000:00:10.3[D] -> GSI 21 (level, low) -> IRQ 17
PCI: Via IRQ fixup for 0000:00:10.3, from 10 to 1
ehci_hcd 0000:00:10.3: VIA Technologies, Inc. USB 2.0
ehci_hcd 0000:00:10.3: new USB bus registered, assigned bus number 1 --
USB Universal Host Controller Interface driver v2.3
ACPI: PCI Interrupt 0000:00:10.0[A] -> GSI 21 (level, low) -> IRQ 17
PCI: Via IRQ fixup for 0000:00:10.0, from 11 to 1
uhci_hcd 0000:00:10.0: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1 Controller uhci_hcd 0000:00:10.0: new USB bus registered, assigned bus number 2 --
hub 2-0:1.0: 2 ports detected
ACPI: PCI Interrupt 0000:00:10.1[B] -> GSI 21 (level, low) -> IRQ 17
PCI: Via IRQ fixup for 0000:00:10.1, from 11 to 1
uhci_hcd 0000:00:10.1: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1 Controller (#2) uhci_hcd 0000:00:10.1: new USB bus registered, assigned bus number 3 --
hub 3-0:1.0: 2 ports detected
ACPI: PCI Interrupt 0000:00:10.2[C] -> GSI 21 (level, low) -> IRQ 17
PCI: Via IRQ fixup for 0000:00:10.2, from 10 to 1
uhci_hcd 0000:00:10.2: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1 Controller (#3) uhci_hcd 0000:00:10.2: new USB bus registered, assigned bus number 4 --
For more details, read ALSA-Configuration.txt.
ACPI: PCI Interrupt 0000:00:11.5[C] -> GSI 22 (level, low) -> IRQ 21
PCI: Via IRQ fixup for 0000:00:11.5, from 10 to 5
PCI: Setting latency timer of device 0000:00:11.5 to 64
Floppy drive(s): fd0 is 1.44M

#11 lore raw

Le Wed, 28 Sep 2005 09:28:56 +0200, Matthieu CASTET a écrit :

Quoted 11 lines

Hi Linus,

Le Tue, 27 Sep 2005 15:58:33 -0700, Linus Torvalds a écrit :

Quoted 6 lines

so my patch didn't change anything at all for you (which is correct - it was designed not to ;)

Quoted 6 lines

It will for me as I have [1].

But since the irq for ide are probe after, I think it won't change anything.
I will try your patch when I'll have some free time.

Seem to work fine here (disable all fix).