utilization of kprobe_mutex is incorrect on x86_64
Quoted 7 lines · Yanmin
Quoted 4 lines
<<kprobe_incorrect_kprobe_mutex_2.6.14-rc2_x86_64.patch>> I found it
when reading the source codes. Basically, the bug could breakkprobe_insn_pagesunder multi-thread environment. PPC arch also has the problem.Can you describe what the problem actually is?
Andi,
The up()/down() orders are incorrect in arch/x86_64/kprobes.c file while trying to get/remove a kprobes instruction slot in arch_prepare_kprobe() and arch_remove_kprobe() routines. Zhang's patch corrects this.
Thanks
Prasanna
Signature · 5 lines
Prasanna S Panchamukhi Linux Technology Center India Software Labs, IBM Bangalore Ph: 91-80-25044636 <[email protected]>
Quoted 6 lines · Prasanna S Panchamukhi
Quoted 6 lines · Yanmin
Quoted 4 lines
<<kprobe_incorrect_kprobe_mutex_2.6.14-rc2_x86_64.patch>> I found it
when reading the source codes. Basically, the bug could breakkprobe_insn_pagesunder multi-thread environment. PPC arch also has the problem.
Quoted 7 lines
Quoted 1 line
Can you describe what the problem actually is?
Andi,
The up()/down() orders are incorrect in
arch/x86_64/kprobes.cfile while trying to get/remove a kprobes instruction slot inarch_prepare_kprobe()andarch_remove_kprobe()routines. Zhang's patch corrects this.
What I meant is that someone should describe why they are incorrect. I could probably figure it out from the code, but in general the standards for changelogs are higher than just "bla is wrong". It should be more like "bla doesn't do X, so bad thing Y happens, which causes crash Z". Please follow this in future patches.
-Andi