Skip to contentSkip to conversation

Fix bogus cast in IXP2000 I/O macro

PATCH New Deepak Saxena 1 participant 1 message Sep 29, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix bogus cast in IXP2000 I/O macro

Physical addresses are not valid pointers of any sort and should not be cast to such.

include/asm-arm/arch-ixp2000/ixdp2x01.h +1 -1
@@ -22,7 +22,7 @@
 #define	IXDP2X01_CPLD_REGION_SIZE	0x00100000
 
 #define IXDP2X01_CPLD_VIRT_REG(reg) (volatile unsigned long*)(IXDP2X01_VIRT_CPLD_BASE | reg)
-#define IXDP2X01_CPLD_PHYS_REG(reg) (volatile u32*)(IXDP2X01_PHYS_CPLD_BASE | reg)
+#define IXDP2X01_CPLD_PHYS_REG(reg) (IXDP2X01_PHYS_CPLD_BASE | reg)
 
 #define IXDP2X01_UART1_VIRT_BASE	IXDP2X01_CPLD_VIRT_REG(0x40)
 #define IXDP2X01_UART1_PHYS_BASE	IXDP2X01_CPLD_PHYS_REG(0x40)
Signature · 3 lines
Deepak Saxena - [email protected] - http://www.plexity.net

Even a stopped clock gives the right time twice a day.