AMD Geode GX/LX support
PATCH 5/7 AMD Geode GX/LX support
The following is a patch enabling IDE DMA for the CS5535 companion chip. linux-ide folks, this is an updated version of the patch that was submitted
last night by Jaya Kumar. Both patches share the same history, and probably
the same bugs too. Please apply against linux-2.6.14-rc2-mm2.
Signed off by: Jordan Crouse ([email protected])
drivers/ide/Kconfig +8 -0
@@ -539,6 +539,14 @@ config BLK_DEV_CS5530 It is safe to say Y to this question. +config BLK_DEV_CS5535 + tristate "AMD CS5535 chipset support" + help + Include support for UDMA on the National Semiconductor/AMD 5535 + chipset. This will automatically be detected and configured if found. + + It is safe to say Y to this question. + config BLK_DEV_HPT34X tristate "HPT34X chipset support" help
drivers/ide/pci/Makefile +1 -0
@@ -6,6 +6,7 @@ obj-$(CONFIG_BLK_DEV_ATIIXP) += atiixp. obj-$(CONFIG_BLK_DEV_CMD64X) += cmd64x.o obj-$(CONFIG_BLK_DEV_CS5520) += cs5520.o obj-$(CONFIG_BLK_DEV_CS5530) += cs5530.o +obj-$(CONFIG_BLK_DEV_CS5535) += cs5535.o obj-$(CONFIG_BLK_DEV_SC1200) += sc1200.o obj-$(CONFIG_BLK_DEV_CY82C693) += cy82c693.o obj-$(CONFIG_BLK_DEV_HPT34X) += hpt34x.o
drivers/ide/pci/cs5535.c new file +352 -0
352 lines not on this page · raw message
drivers/ide/pci/cs5535.h new file +72 -0
72 lines not on this page · raw message
drivers/ide/pci/cs5535.c line 291
Quoted 5 lines · Jordan Crouse
drivers/ide/pci/cs5535.c new file +5
-0+ + hwif->udma_four = w80;/* w80 = 1 if a 80 conductor line is attached */ + +if (hwif->mate) + hwif->serialized = hwif->mate->serialized =1 ;
Is this needed, it doesn't seem to be in the databook or errata ?
drivers/ide/pci/cs5535.h
Quoted 5 lines
Index:
linux-2.6.14-rc2-mm2/drivers/ide/pci/cs5535.h
===================================================================drivers/ide/pci/cs5535.h new file +0
-0@@ -0,0 +1,72 @@
Please put the private structure into the .c file as the other code now does. Its a tidy up that wants picking up.
Hi,
Quoted 3 lines · Jordan Crouse
The following is a patch enabling IDE DMA for the CS5535 companion chip. linux-ide folks, this is an updated version of the patch that was submitted
last night by Jaya Kumar. Both patches share the same history, and probably
Unfortunately it is not updated version of Jaya's patch but the updated version of the original 2.6.x patch and it misses 2 iterations of bugfixes/cleanups:
http://marc.theaimsgroup.com/?l=linux-ide&m=112832700817260&w=2
Quoted 1 line
From what I see the main differences between _original_ patch and this one are:
* /proc/ide/cs5535 (sorry but new /proc bloat won't be accepted)
* different way of setting PIO command timings
(but this method won't ever set timings > 0 if initially timings were bad)
* trusting BIOS to set correct mode also on drive's side (this breaks Power Management support and I will prefer to have known state from Linux POV)
It would be the best to join efforts so could somebody from AMD take a look at Jaya's latest patch and read related linux-ide ML thread?
Thanks,
Bartlomiej