Skip to contentSkip to conversation

i2c: Rename i2c-parport variable to

PATCH New Jean Delvare 1 participant 1 message Oct 8, 2005

Subsystems (2)
I2C subsystem host drivers I2C over parallel port
lore
Share & tools
lore

Jean Delvare

author
#0 lore raw

PATCH 13/16 i2c: Rename i2c-parport variable to

It's a bit confusing to name a variable the same as an unrelated structure. The compiler doesn't complain, but it certainly makes the code harder to understand, and could confuse grep and LXR among others.

Signed-off-by Jean Delvare <[email protected]>
 drivers/i2c/busses/i2c-parport.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/i2c/busses/i2c-parport.c +3 -3
@@ -232,7 +232,7 @@
 	}
 }
 
-static struct parport_driver i2c_driver = {
+static struct parport_driver i2c_parport_driver = {
 	.name	= "i2c-parport",
 	.attach	= i2c_parport_attach,
 	.detach	= i2c_parport_detach,

@@ -250,12 +250,12 @@
 		type = 0;
 	}
 	
-	return parport_register_driver(&i2c_driver);
+	return parport_register_driver(&i2c_parport_driver);
 }
 
 static void __exit i2c_parport_exit(void)
 {
-	parport_unregister_driver(&i2c_driver);
+	parport_unregister_driver(&i2c_parport_driver);
 }
 
 MODULE_AUTHOR("Jean Delvare <[email protected]>");
Signature · 1 line
Jean Delvare