i386: Don't discard upper 32bits of HWCR on K8

PATCH New Andi Kleen 1 participant 1 message Oct 10, 2005

Share & tools

Andi Kleen

author

2005-10-10 23:28 UTC #0 lore raw

PATCH 1/1 i386: Don't discard upper 32bits of HWCR on K8

Need to use long long, not long when RMWing a MSR. I think it's harmless right now, but still should be better fixed if AMD adds any bits in the upper 32bit of HWCR.

Bug was introduced with the TLB flush filter fix for i386

Signed-off-by Andi Kleen <[email protected]>

arch/i386/kernel/cpu/amd.c +1 -1

Index: linux/arch/i386/kernel/cpu/amd.c
===================================================================
@@ -29,7 +29,7 @@ static void __init init_amd(struct cpuin
 	int r;
 
 #ifdef CONFIG_SMP
-	unsigned long value;
+	unsigned long long value;
 
 	/* Disable TLB flush filter by setting HWCR.FFDIS on K8
 	 * bit 6 of msr C001_0015