Skip to contentSkip to conversation

ppc64: Fix typo bug in iSeries hash code

PATCH David Gibson 1 participant 1 message Oct 21, 2005

lore
Share & tools
lore
#0 lore raw

Linus, please apply for 2.6.14 - this one-liner fixes a serious bug.

This patch fixes a stupid typo bug in the iSeries hash table code. When we place a hash PTE in the secondary bucket, instead of setting the SECONDARY flag bit, as we should, we (redundantly) set the VALID flag. This was introduced with the patch abolishing bitfields from the hash table code. Mea culpa, oops. It hasn't been noticed until now because in practice we don't hit the secondary bucket terribly often.

arch/ppc64/kernel/iSeries_htab.c +1 -1
Index: working-2.6/arch/ppc64/kernel/iSeries_htab.c
===================================================================
@@ -66,7 +66,7 @@
 	}
 
 	if (slot < 0) {		/* MSB set means secondary group */
-		vflags |= HPTE_V_VALID;
+		vflags |= HPTE_V_SECONDARY;
 		secondary = 1;
 		slot &= 0x7fffffffffffffff;
 	}
Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/people/dgibson