Skip to contentSkip to conversation

kill max_back_kb handling

PATCH In review Tejun Heo 2 participants 3 messages Oct 24, 2005 Block layer

lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

PATCH 1/1 kill max_back_kb handling

Hello, Jens.

This patch kills max_back_kb handling from elv_dispatch_sort() and
kills max_back_kb field from struct request_queue. The implementation was broken (subtracted bytes from blocks) and the usefulness of the feature is doubtful.

drivers/block/elevator.c +1 -5
@@ -136,7 +136,6 @@ static int elevator_attach(request_queue
 	q->elevator = eq;
 	q->end_sector = 0;
 	q->boundary_rq = NULL;
-	q->max_back_kb = 0;
 
 	if (eq->ops->elevator_init_fn)
 		ret = eq->ops->elevator_init_fn(q, eq);
@@ -227,16 +226,13 @@ void elevator_exit(elevator_t *e)
 void elv_dispatch_sort(request_queue_t *q, struct request *rq)
 {
 	sector_t boundary;
-	unsigned max_back;
 	struct list_head *entry;
 
 	if (q->last_merge == rq)
 		q->last_merge = NULL;
 
 	boundary = q->end_sector;
-	max_back = q->max_back_kb * 2;
-	boundary = boundary > max_back ? boundary - max_back : 0;
-	
+
 	list_for_each_prev(entry, &q->queue_head) {
 		struct request *pos = list_entry_rq(entry);
 
include/linux/blkdev.h +0 -1
@@ -339,7 +339,6 @@ struct request_queue
 	 */
 	sector_t		end_sector;
 	struct request		*boundary_rq;
-	unsigned int		max_back_kb;
 
 	/*
 	 * Auto-unplugging state
author
#1 lore raw
Quoted 5 lines · Tejun Heo

Hello, Jens.

This patch kills max_back_kb handling from elv_dispatch_sort() and
kills max_back_kb field from struct request_queue. The implementation was broken (subtracted bytes from blocks) and the usefulness of the

Oops, above line is wrong. Can you please kill the sentence about
breakage when committing? Thanks.

Quoted 1 line

feature is doubtful.

Signature · 1 line
tejun
#2 lore raw
Quoted 9 lines · Tejun Heo
Quoted 5 lines · Tejun Heo

Hello, Jens.

This patch kills max_back_kb handling from elv_dispatch_sort() and
kills max_back_kb field from struct request_queue. The implementation was broken (subtracted bytes from blocks) and the usefulness of the

Oops, above line is wrong. Can you please kill the sentence about
breakage when committing? Thanks.

Sure, committed.

Signature · 1 line
Jens Axboe