Skip to contentSkip to conversation

Comments on serial and MMC changes in MIPS merge

FIXME Russell King 3 participants 3 messages Oct 29, 2005 – Oct 31, 2005

lore
Share & tools
lore
#0 lore raw

Some comments on the recent MIPS merge:

1. au1xxx mmc driver

mmc_remove_host() does a safe shutdown of the MMC host, removing cards and then powering down. This must be called prior to the driver thinking of tearing anything down.

As for those disable_irq()...enable_irq(), are you aware that MMC can start talking to the host as soon as you've called mmc_add_host() ?

2. IP3106 serial driver

   -#define PORT_MAX_8250  15      /* max port ID */
   +#define PORT_IP3106    16
   +#define PORT_MAX_8250  16      /* max port ID */

Do not add new port numbers after the 8250 port number range. Add them on the end of the list.

Since this will get in the way of additional 8250 ports, it's a serious problem. Please fix ASAP.

(btw, I notice that this change was _not_ included with the
IP3106 driver you sent for review.)

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
#1 lore raw
Quoted 11 lines · Russell King

Some comments on the recent MIPS merge:

1. au1xxx mmc driver

mmc_remove_host() does a safe shutdown of the MMC host, removing cards and then powering down. This must be called prior to the driver thinking of tearing anything down.

As for those disable_irq()...enable_irq(), are you aware that MMC can start talking to the host as soon as you've called mmc_add_host() ?

I'm also concerned about the ammount of protocol awareness in this driver. Is there a spec available for this hardware? Perhaps the MMC layer can export more information so that we can avoid switches on specific MMC commands?

Rgds
Pierre

#2 lore raw
Quoted 6 lines · Pierre Ossman
Quoted 6 lines

1. au1xxx mmc driver

mmc_remove_host() does a safe shutdown of the MMC host, removing cards and then powering down. This must be called prior to the driver thinking of tearing anything down.

Quoted 8 lines
Quoted 3 lines

As for those disable_irq()...enable_irq(), are you aware that MMC can start talking to the host as soon as you've called mmc_add_host() ?

I'm also concerned about the ammount of protocol awareness in this driver. Is there a spec available for this hardware? Perhaps the MMC layer can export more information so that we can avoid switches on specific MMC commands?

Cc'ed to ppopov, the actual author.

Ralf