Skip to contentSkip to conversation

core remove PageReserved

PATCH Dave Jones 2 participants 2 messages Nov 4, 2005 1 message not in the archive

lore
Share & tools
lore

Dave Jones

author
#1 lore raw
In reply to a message not in the archive
Quoted 12 lines · Linux Kernel

tree 835836cb527ec9bd525f93eb7e016f3dfb8c8ae2
parent f9c98d0287de42221c624482fd4f8d485c98ab22
author Nick Piggin <[email protected]> Sun, 30 Oct 2005 08:16:12 -0700 committer Linus Torvalds <[email protected]> Sun, 30 Oct 2005 11:40:39 -0700

[PATCH] core remove PageReserved

Remove PageReserved() calls from core code by tightening VM_RESERVED handling in mm/ to cover PageReserved functionality.

PageReserved special casing is removed from get_page and put_page.

Quoted 7 lines

All setting and clearing of PageReserved is retained, and it is now flagged in the page_alloc checks to help ensure we don't introduce any refcount based freeing of Reserved pages.

MAP_PRIVATE, PROT_WRITE of VM_RESERVED regions is tentatively being deprecated. We never completely handled it correctly anyway, and is be reintroduced in future if required (Hugh has a proof of concept).

We've got one user reporting that he's getting the following message..

"program ddcprobe is using MAP_PRIVATE, PROT_WRITE mmap of VM_RESERVED memory" since this cset.

So what should happen here, does that app need changing? Or do we just need to get Hugh's changes merged?

It's likely that anything else that uses lrmi is going to be affected in the same way, though off the top of my head, I don't know what (if any) other apps there may be.

Dave

#2 lore raw
Quoted 21 lines · Dave Jones
Quoted 12 lines · Linux Kernel

tree 835836cb527ec9bd525f93eb7e016f3dfb8c8ae2
parent f9c98d0287de42221c624482fd4f8d485c98ab22
author Nick Piggin <[email protected]> Sun, 30 Oct 2005 08:16:12 -0700 committer Linus Torvalds <[email protected]> Sun, 30 Oct 2005 11:40:39 -0700

[PATCH] core remove PageReserved

Remove PageReserved() calls from core code by tightening VM_RESERVED handling in mm/ to cover PageReserved functionality.

PageReserved special casing is removed from get_page and put_page.

Quoted 7 lines

All setting and clearing of PageReserved is retained, and it is now flagged in the page_alloc checks to help ensure we don't introduce any refcount based freeing of Reserved pages.

MAP_PRIVATE, PROT_WRITE of VM_RESERVED regions is tentatively being deprecated. We never completely handled it correctly anyway, and is be reintroduced in future if required (Hugh has a proof of concept).

Quoted 9 lines

We've got one user reporting that he's getting the following message..

"program ddcprobe is using MAP_PRIVATE, PROT_WRITE mmap of VM_RESERVED memory" since this cset.

So what should happen here, does that app need changing? Or do we just need to get Hugh's changes merged?

Thanks for reporting this.

Can the app use MAP_SHARED? Or PROT_READ and copy the mapped page to its own private one before modifying it?

It is likely to only be very specific userspace drivers and stuff that would ever do this... but if they become a real problem then Hugh's patch would be able to solve it. Though I'd like to try to avoid relying on that if possible.

Perhaps the nice thing to do would be to include Hugh's patch *and* display the warning message, and remove the functionality in a later release.

Signature · 3 lines
SUSE Labs, Novell Inc.

Send instant messages to your online friends http://au.messenger.yahoo.com