Skip to contentSkip to conversation

let CIFS_EXPERIMENTAL depend on EXPERIMENTAL

PATCH In review Adrian Bunk 1 participant 2 messages Oct 31, 2005 – Nov 2, 2005 1 message not in the archive VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 let CIFS_EXPERIMENTAL depend on EXPERIMENTAL

It seems logical.

Note that CONFIG_EXPERIMENTAL itself doesn't enable any code.

---

This patch was already sent on:
- 21 Jul 2005

fs/Kconfig renamed from fs/Kconfig.old +1 -1
@@ -1804,7 +1804,7 @@
 
 config CIFS_EXPERIMENTAL
 	  bool "CIFS Experimental Features (EXPERIMENTAL)"
-	  depends on CIFS
+	  depends on CIFS && EXPERIMENTAL
 	  help
 	    Enables cifs features under testing. These features
 	    are highly experimental.  If unsure, say N.
#2 lore raw
In reply to a message not in the archive
Quoted 3 lines · Steven French

If users really remember that CONFIG_EXPERIMENTAL does not enable anything than it is probably a good idea -

I'd express it differently:

People interested in experimental options like CIFS_EXPERIMENTAL did already enable EXPERIMENTAL.

Quoted 5 lines

There is a minor problem - ie that there are some features in CIFS that with 2.6.14 out are no longer really experimental that need to be pulled
out of the ifdef. I have a pretty big cifs merge to do, but I have no
real problem with your patch (we have enough time to add one or two more cifs config options, clean up others)

I don't see any problem with this.

It's quite normal that code moves out of an EXPERIMENTAL option once it's matured.

Quoted 1 line

Steve French

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed