remove ext2 xattr permission checks
Subsystems (2)
PATCH 4/8 remove ext2 xattr permission checks
remove checks now in the VFS
Signed-off-by Christoph Hellwig <[email protected]>
fs/ext2/xattr.c +0 -4
@@ -389,10 +389,6 @@ea_idebug (inode,"name=%d.%s, value=%p, value_len=%ld" , name_index, name, value, (long )value_len); -if (IS_RDONLY (inode)) -return -EROFS ; -if (IS_IMMUTABLE (inode) ||IS_APPEND (inode)) -return -EPERM ;if (value ==NULL ) value_len =0 ;if (name ==NULL )
fs/ext2/xattr_trusted.c +0 -4
@@ -38,8 +38,6 @@ {if (strcmp (name,"" ) ==0 )return -EINVAL ; -if (!capable (CAP_SYS_ADMIN )) -return -EPERM ;return ext2_xattr_get (inode,EXT2_XATTR_INDEX_TRUSTED , name, buffer, size); }
@@ -50,8 +48,6 @@ {if (strcmp (name,"" ) ==0 )return -EINVAL ; -if (!capable (CAP_SYS_ADMIN )) -return -EPERM ;return ext2_xattr_set (inode,EXT2_XATTR_INDEX_TRUSTED , name, value, size, flags); }
fs/ext2/xattr_user.c +0 -10
@@ -41,10 +41,6 @@return -EINVAL ;if (!test_opt (inode->i_sb,XATTR_USER ))return -EOPNOTSUPP ; - error =permission (inode,MAY_READ ,NULL ); -if (error) -return error; -return ext2_xattr_get (inode,EXT2_XATTR_INDEX_USER , name, buffer, size); }
@@ -58,12 +54,6 @@return -EINVAL ;if (!test_opt (inode->i_sb,XATTR_USER ))return -EOPNOTSUPP ; -if ( !S_ISREG (inode->i_mode) && - (!S_ISDIR (inode->i_mode) || inode->i_mode &S_ISVTX )) -return -EPERM ; - error =permission (inode,MAY_WRITE ,NULL ); -if (error) -return error;return ext2_xattr_set (inode,EXT2_XATTR_INDEX_USER , name, value, size, flags);