+ swap-migration-v5-lru-operations-tweaks.patch added to -mm tree
A message that is not in the archive (sent off-list or not yet received): [email protected]
2005/11/1, [email protected] <[email protected]>:
Quoted 24 lines
The patch titled
swap-migration-v5-lru-operations-tweaks
has been added to the -mm tree. Its filename is
swap-migration-v5-lru-operations-tweaks.patch
From: Andrew Morton <[email protected]>
Cc Christoph Lameter <[email protected]>Signed-off-by Andrew Morton <[email protected]>---
include/linux/mm_inline.h | 4 +--- mm/vmscan.c | 6 +++--- 2 files changed, 4 insertions(+), 6 deletions(-)diff -puN
include/linux/mm_inline.h~swap-migration-v5-lru-operations-tweaksinclude/linux/mm_inline.h
include/linux/mm_inline.h 2005-10-31 21:21:48.000000000 -0800 del_page_from_lru(struct zone *zone, str · line 50
Quoted 9 lines
include/linux/mm_inline.h 2005-10-31 21:21:48.000000000 -0800 renamed from include/linux/mm_inline.h~swap-migration-v5-lru-operations-tweaks 2005-10-31 21:21:48.000000000 -0800 +1
-2@@ -44,8 +44,7 @@ del_page_from_lru(struct zone *zone, str * * - zone->lru_lock must be held */ -static inline int -__isolate_lru_page(struct zone *zone, struct page *page) +static inline int __isolate_lru_page(struct zone *zone, struct page *page) { if (TestClearPageLRU(page)) { if (get_page_testone(page)) {
My curiosity, why we do this when the former is friendly to grep? Any coding style document about this?
--
Coywolf Qi Hunt
http://sosdg.org/~coywolf/
Quoted 22 lines · Coywolf Qi Hunt
2005/11/1, [email protected] <[email protected]>:
Quoted 20 lines
The patch titled
swap-migration-v5-lru-operations-tweaks
has been added to the -mm tree. Its filename is
swap-migration-v5-lru-operations-tweaks.patch
From: Andrew Morton <[email protected]>
Cc Christoph Lameter <[email protected]>Signed-off-by Andrew Morton <[email protected]>---
include/linux/mm_inline.h | 4 +--- mm/vmscan.c | 6 +++--- 2 files changed, 4 insertions(+), 6 deletions(-)
Quoted 15 lines
include/linux/mm_inline.h 2005-10-31 21:21:48.000000000 -0800 del_page_from_lru(struct zone *zone, str · line 50
Quoted 13 lines
diff -puN
include/linux/mm_inline.h~swap-migration-v5-lru-operations-tweaksinclude/linux/mm_inline.hinclude/linux/mm_inline.h 2005-10-31 21:21:48.000000000 -0800 renamed from include/linux/mm_inline.h~swap-migration-v5-lru-operations-tweaks 2005-10-31 21:21:48.000000000 -0800 +1
-2@@ -44,8 +44,7 @@ del_page_from_lru(struct zone *zone, str * * - zone->lru_lock must be held */ -static inline int -__isolate_lru_page(struct zone *zone, struct page *page) +static inline int __isolate_lru_page(struct zone *zone, struct page *page) { if (TestClearPageLRU(page)) { if (get_page_testone(page)) {My curiosity, why we do this when the former is friendly to grep?
It's easier to read.
Quoted 1 line
Any coding style document about this?
Dunno. I have a rude email from Linus here somewhere from when I used to do it that way ;)