Skip to contentSkip to conversation

nf_conntrack: fixes for nfsim-found problems

PATCH In review KOVACS Krisztian 2 participants 2 messages Nov 5, 2005 netfilter

lore
Share & tools
lore
#0 lore raw

cover nf_conntrack: fixes for nfsim-found problems

Hi,

These patches are fixes for nf_conntrack problems found by nfsim.
Please review and apply them if you find them appropriate.

Signature · 2 lines
 Regards,
  Krisztian Kovacs
#1 lore raw

From: KOVACS Krisztian <[email protected]>
Date: Sat, 5 Nov 2005 12:54:20 +0100

Quoted 2 lines

These patches are fixes for nf_conntrack problems found by nfsim.
Please review and apply them if you find them appropriate.

Thanks a lot! These look fine to me except following comment in 2nd patch.

Review

Quoted 6 lines
(quoted diff) +6 -0
+	/* free l3proto protocol tables */
+	for (i = 0; i < PF_MAX; i++)
+		if (nf_ct_protos[i]) {
+			kfree(nf_ct_protos[i]);
+			nf_ct_protos[i] = NULL;
+		}

nf_ct_protos is the table for layer 4 protocol, not layer 3.

Regards,

-- Yasuyuki Kozakai