Skip to contentSkip to conversation

fec_8xx: make CONFIG_FEC_8XX depend on CONFIG_8xx

PATCH In review John W. Linville 2 participants 5 messages Nov 6, 2005 – Nov 9, 2005

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

John W. Linville

author
#0 lore raw

PATCH 1/1 fec_8xx: make CONFIG_FEC_8XX depend on CONFIG_8xx

Make CONFIG_FEC_8XX depend on CONFIG_8xx. This keeps allmodconfig from breaking on non-8xx (PPC) platforms.

Signed-off-by John W. Linville <[email protected]>

---

 drivers/net/fec_8xx/Kconfig |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/net/fec_8xx/Kconfig +1 -1
index 4560026..a84c232 100644
@@ -1,6 +1,6 @@
 config FEC_8XX
 	tristate "Motorola 8xx FEC driver"
-	depends on NET_ETHERNET
+	depends on NET_ETHERNET && 8xx
 	select MII
 
 config FEC_8XX_GENERIC_PHY
Signature · 2 lines
John W. Linville
[email protected]
#1 lore raw
Quoted 14 lines · John W. Linville

Make CONFIG_FEC_8XX depend on CONFIG_8xx. This keeps allmodconfig from breaking on non-8xx (PPC) platforms.

Signed-off-by John W. Linville <[email protected]>

---

 drivers/net/fec_8xx/Kconfig |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/net/fec_8xx/Kconfig +0 -0
index 4560026..a84c232 100644

drivers/net/fec_8xx/Kconfig line 6

Quoted 7 lines
drivers/net/fec_8xx/Kconfig +1 -1
@@ -1,6 +1,6 @@
 config FEC_8XX
 	tristate "Motorola 8xx FEC driver"
-	depends on NET_ETHERNET
+	depends on NET_ETHERNET && 8xx
 	select MII
 
 config FEC_8XX_GENERIC_PHY

Yes, this is the correct approach. Please disregard the other patches floating about.

Regards

Pantelis

author
#2 lore raw
Quoted 9 lines · Pantelis Antoniou
Quoted 7 lines · John W. Linville
(quoted diff) +0 -0
@@ -1,6 +1,6 @@

config FEC_8XX
tristate "Motorola 8xx FEC driver"

drivers/net/fec_8xx/Kconfig +1 -1
-	depends on NET_ETHERNET
+	depends on NET_ETHERNET && 8xx

select MII

Quoted 4 lines
Quoted 1 line

config FEC_8XX_GENERIC_PHY

Yes, this is the correct approach. Please disregard the other patches floating about.

Pretty sure you are right. However, a broken version already got committed. It added FEC as a dependency. That keeps it from breaking everyone else, but it make the driver available for Coldfire rather than for PPC 8xx...

I'll reform that patch and repost.

John

Signature · 2 lines
John W. Linville
[email protected]
author
#3 lore raw

PATCH 1/1 fec_8xx: make CONFIG_FEC_8XX depend on CONFIG_8xx

Change CONFIG_FEC_8XX to depend on CONFIG_8xx instead of CONFIG_FEC. CONFIG_FEC depends on ColdFire CPUs, which does not apply for the PPC 8xx processors.

Signed-off-by John W. Linville <[email protected]>

---

 drivers/net/fec_8xx/Kconfig |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/net/fec_8xx/Kconfig +1 -1
index 94e7a9a..a84c232 100644
@@ -1,6 +1,6 @@
 config FEC_8XX
 	tristate "Motorola 8xx FEC driver"
-	depends on NET_ETHERNET && FEC
+	depends on NET_ETHERNET && 8xx
 	select MII
 
 config FEC_8XX_GENERIC_PHY
Signature · 2 lines
John W. Linville
[email protected]
author
#4 lore raw
Quoted 3 lines · John W. Linville

Change CONFIG_FEC_8XX to depend on CONFIG_8xx instead of CONFIG_FEC. CONFIG_FEC depends on ColdFire CPUs, which does not apply for the PPC 8xx processors.

FWIW, I have this patch available on the linville-fec_8xx branch of netdev-jwl as described below.

Thanks,

John

---

The following changes since commit 330d57fb98a916fa8e1363846540dd420e99499a:
Al Viro:

        Fix sysctl unregistration oops (CVE-2005-2709)

are found in the git repository at:

git://git.tuxdriver.com/git/netdev-jwl.git linville-fec_8xx

John W. Linville:
fec_8xx: make CONFIG_FEC_8XX depend on CONFIG_8xx

 drivers/net/fec_8xx/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/fec_8xx/Kconfig +1 -1
index 94e7a9a..a84c232 100644
@@ -1,6 +1,6 @@
 config FEC_8XX
 	tristate "Motorola 8xx FEC driver"
-	depends on NET_ETHERNET && FEC
+	depends on NET_ETHERNET && 8xx
 	select MII
 
 config FEC_8XX_GENERIC_PHY
Signature · 2 lines
John W. Linville
[email protected]