Skip to contentSkip to conversation

Shut up per_cpu_ptr() on UP

PATCH New Paul Mundt 1 participant 1 message Nov 7, 2005 Per-CPU memory allocator

lore
Share & tools
lore

Paul Mundt

author
#0 lore raw

PATCH 1/1 Shut up per_cpu_ptr() on UP

Currently per_cpu_ptr() doesn't really do anything with 'cpu' in the UP case. This is problematic in the cases where this is the only place the variable is referenced:

CC kernel/workqueue.o
kernel/workqueue.c: In function `current_is_keventd':
kernel/workqueue.c:460: warning: unused variable `cpu'

How about something like this?

include/linux/percpu.h +1 -1
index 5451eb1..fb8d2d2 100644
@@ -38,7 +38,7 @@ extern void free_percpu(const void *);
 
 #else /* CONFIG_SMP */
 
-#define per_cpu_ptr(ptr, cpu) (ptr)
+#define per_cpu_ptr(ptr, cpu) ({ (void)(cpu); (ptr); })
 
 static inline void *__alloc_percpu(size_t size, size_t align)
 {