Skip to contentSkip to conversation

My tools break here

PATCH In review Zachary Amsden 4 participants 7 messages Nov 7, 2005 – Nov 10, 2005 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 My tools break here

I have to revert the recent addition of -imacros to the Makefile to get my tool chain to build. Without the change, below, I get:

Note that this looks entirely like a toolchain bug. Here is the offending command:

[pid 12163] execve("/usr/lib/gcc-lib/i386-redhat-linux/3.2.2/tradcpp0", ["/usr/lib/gcc-lib/i386-redhat-linux/3.2.2/tradcpp0", "-lang-asm", "-nostdinc", "-Iinclude", "-Iinclude/asm-i386/mach-default", "-D__GNUC__=3", "-D__GNUC_MINOR__=2", "-D__GNUC_PATCHLEVEL__=2", "-D__GXX_ABI_VERSION=102", "-D__ELF__", "-Dunix", "-D__gnu_linux__", "-Dlinux", "-D__ELF__", "-D__unix__", "-D__gnu_linux__", "-D__linux__", "-D__unix", "-D__linux", "-Asystem=posix", "-D__NO_INLINE__", "-D__STDC_HOSTED__=1", "-Acpu=i386", "-Amachine=i386", "-Di386", "-D__i386", "-D__i386__", "-D__tune_i386__", "-D__KERNEL__", "-D__ASSEMBLY__", "-isystem", "/usr/lib/gcc-lib/i386-redhat-linux/3.2.2/include", "-imacros", "include/linux/autoconf.h", "-MD", "arch/i386/kernel/.entry.o.d", "arch/i386/kernel/entry.S", "-o", "/tmp/ccOlsFJR.s"]

Which should execute properly, I think. But it does not:

zach-dev:linux-2.6.14-zach-work $ make

  CHK     include/linux/version.h
  CHK     include/linux/compile.h
  CHK     usr/initramfs_list
  AS      arch/i386/kernel/entry.o

/usr/lib/gcc-lib/i386-redhat-linux/3.2.2/tradcpp0: output filename specified twice make[1]: *** [arch/i386/kernel/entry.o] Error 1
make: *** [arch/i386/kernel] Error 2

gcc (GCC) 3.2.2 20030222 (Red Hat Linux 3.2.2-5)

Deprecating the -imacros fixes the build for me. It does not appear to be a simple argument overflow problem in trapcpp0, since deprecating all the defines reproduces the problem as well. Also, switching -imacros to -include fixes the problem.

Makefile +1 -2
Index: linux-2.6.14-zach-work/Makefile
===================================================================
@@ -346,8 +346,7 @@ AFLAGS_KERNEL	=
 # Use LINUXINCLUDE when you must reference the include/ directory.
 # Needed to be compatible with the O= option
 LINUXINCLUDE    := -Iinclude \
-                   $(if $(KBUILD_SRC),-Iinclude2 -I$(srctree)/include) \
-		   -imacros include/linux/autoconf.h
+                   $(if $(KBUILD_SRC),-Iinclude2 -I$(srctree)/include)
 
 CPPFLAGS        := -D__KERNEL__ $(LINUXINCLUDE)
 
#1 lore raw
Quoted 4 lines · Zachary Amsden

I have to revert the recent addition of -imacros to the Makefile to get my tool chain to build. Without the change, below, I get:

Note that this looks entirely like a toolchain bug.

Then fix your toolchain instead of reverting the -imacros patch.

The change has been in -git for a full day and in latest -mm too. And so far this is the only report that it breaks - I no one else complains it will stay.

Sam

#2 lore raw
Quoted 7 lines · Sam Ravnborg
Quoted 4 lines · Zachary Amsden

I have to revert the recent addition of -imacros to the Makefile to get my tool chain to build. Without the change, below, I get:

Note that this looks entirely like a toolchain bug.

Then fix your toolchain instead of reverting the -imacros patch.

Well. We work around toolchain bugs regularly.

Quoted 3 lines

The change has been in -git for a full day and in latest -mm too. And so far this is the only report that it breaks - I no one else complains it will stay.

Let's wait and see how many more people are affected.

#3 lore raw
Quoted 6 lines · Andrew Morton
Quoted 4 lines

The change has been in -git for a full day and in latest -mm too. And so far this is the only report that it breaks - I no one else complains it will stay.

Let's wait and see how many more people are affected.

duh. The next bunny is me.

/usr/local/gcc-3.2.1/lib/gcc-lib/i686-pc-linux-gnu/3.2.1/tradcpp0: output filename specified twice

That's a vanilla gcc-3.2.1

Is there any downside to using -include?

#4 lore raw
Quoted 6 lines · Andrew Morton
Quoted 5 lines · Andrew Morton
Quoted 4 lines

The change has been in -git for a full day and in latest -mm too. And so far this is the only report that it breaks - I no one else complains it will stay.

Quoted 7 lines
Quoted 1 line

Let's wait and see how many more people are affected.

duh. The next bunny is me.

/usr/local/gcc-3.2.1/lib/gcc-lib/i686-pc-linux-gnu/3.2.1/tradcpp0: output filename specified twice

That's a vanilla gcc-3.2.1

And Zachary's gcc was a redhat 9.0 native compiler.

Quoted 3 lines

Is there any downside to using -include?

-imacros was simpler according to info gcc.
I've applied Zachary's patch and will push to kernel.org later tonight.

Sam

#5 lore raw
In reply to Sam Ravnborg
Quoted 10 lines · Sam Ravnborg
Quoted 4 lines · Zachary Amsden

I have to revert the recent addition of -imacros to the Makefile to get my tool chain to build. Without the change, below, I get:

Note that this looks entirely like a toolchain bug.

Then fix your toolchain instead of reverting the -imacros patch.

The change has been in -git for a full day and in latest -mm too. And so far this is the only report that it breaks - I no one else complains it will stay.

If more people run into this problem, maybe we should switch to using -include instead (Zachary indicates that this also fixes the problem.)

Let's try not to throw the preverbial baby out with the bath water.

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
#6 lore raw

PATCH 1/1 My tools break here

In reply to Sam Ravnborg
Quoted 6 lines · Sam Ravnborg
Quoted 3 lines · Zachary Amsden

I have to revert the recent addition of -imacros to the Makefile to get my tool chain to build. Without the change, below, I get:

Quoted 10 lines
Quoted 3 lines

Note that this looks entirely like a toolchain bug.

Then fix your toolchain instead of reverting the -imacros patch.

The change has been in -git for a full day and in latest -mm too. And so far this is the only report that it breaks - I no one else complains it will stay.

My tool chain is an unmodified RedHat 9 default install with all updates applied.

Can we at least consider using -include instead of -imacros? I don't think breaking the compile on this tool chain is a good idea, even if it is old.

I have to revert the recent addition of -imacros to the Makefile to get my tool chain to build. Without the change, below, I get:

Note that this looks entirely like a toolchain bug. Here is the offending command:

[pid 12163] execve("/usr/lib/gcc-lib/i386-redhat-linux/3.2.2/tradcpp0", ["/usr/lib/gcc-lib/i386-redhat-linux/3.2.2/tradcpp0", "-lang-asm", "-nostdinc", "-Iinclude", "-Iinclude/asm-i386/mach-default", "-D__GNUC__=3", "-D__GNUC_MINOR__=2", "-D__GNUC_PATCHLEVEL__=2", "-D__GXX_ABI_VERSION=102", "-D__ELF__", "-Dunix", "-D__gnu_linux__", "-Dlinux", "-D__ELF__", "-D__unix__", "-D__gnu_linux__", "-D__linux__", "-D__unix", "-D__linux", "-Asystem=posix", "-D__NO_INLINE__", "-D__STDC_HOSTED__=1", "-Acpu=i386", "-Amachine=i386", "-Di386", "-D__i386", "-D__i386__", "-D__tune_i386__", "-D__KERNEL__", "-D__ASSEMBLY__", "-isystem", "/usr/lib/gcc-lib/i386-redhat-linux/3.2.2/include", "-imacros", "include/linux/autoconf.h", "-MD", "arch/i386/kernel/.entry.o.d", "arch/i386/kernel/entry.S", "-o", "/tmp/ccOlsFJR.s"]

Which should execute properly, I think. But it does not:

zach-dev:linux-2.6.14-zach-work $ make

  CHK     include/linux/version.h
  CHK     include/linux/compile.h
  CHK     usr/initramfs_list
  AS      arch/i386/kernel/entry.o

/usr/lib/gcc-lib/i386-redhat-linux/3.2.2/tradcpp0: output filename specified twice make[1]: *** [arch/i386/kernel/entry.o] Error 1
make: *** [arch/i386/kernel] Error 2

gcc (GCC) 3.2.2 20030222 (Red Hat Linux 3.2.2-5)

Deprecating the -imacros fixes the build for me. It does not appear to be a simple argument overflow problem in trapcpp0, since deprecating all the defines reproduces the problem as well. Also, switching -imacros to -include fixes the problem.

Makefile +1 -1
Index: linux-2.6.14-zach-work/Makefile
===================================================================
@@ -347,7 +347,7 @@ AFLAGS_KERNEL	=
 # Needed to be compatible with the O= option
 LINUXINCLUDE    := -Iinclude \
                    $(if $(KBUILD_SRC),-Iinclude2 -I$(srctree)/include) \
-		   -imacros include/linux/autoconf.h
+		   -include include/linux/autoconf.h
 
 CPPFLAGS        := -D__KERNEL__ $(LINUXINCLUDE)