Skip to contentSkip to conversation

Does anyone undefine APM_RELAX_SEGMENTS?

DISCUSSION Zachary Amsden 1 participant 1 message Nov 15, 2005 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 22 lines · Rohit Seth
Quoted 19 lines · On Thu, 2005-11-10 at 00:23 -0800, [email protected] wrote:

The patch titled

x86: Always relax segments

has been added to the -mm tree. Its filename is

x86-always-relax-segments.patch

From: Zachary Amsden <[email protected]>

APM BIOSes have many bugs regarding proper representation of the appropriate segment limits for calling the BIOS. By default, APM_RELAX_SEGMENTS is always turned on to support running the APM BIOS on these buggy machines. Keeping 64k limits poses very little danger to the kernel, because the pages where the APM BIOS is located will always be in low physical memory BIOS areas, which should already be marked reserved, and only buggy BIOSes would possibly overstep the segment bounds with writes to data anyway.

Quoted 10 lines
Quoted 6 lines

Since forcing stricter limits breaks many machines and is not default behavior, it seems reasonable to deprecate the older code which may cause APM BIOS to fault.

But I presume it make some other machines to work?

It would make the APM thread panic on machines with broken APM BIOS - which is not very useful except for proving a BIOS bug. But APM is inherently safer than PnP, since there is no transfer segment which can corrupt arbitrary kernel memory.

In the history of its introduction, I can not find a single distribution or use which undefines this macro. If anyone knows otherwise, please advise.

Zach