parisc: remove copat_ioctl entires for pp
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 8 lines · Christoph Hellwig
ppp ioctls handlers in parisc are wrong:
- they would need to do a
copat_ptronifr->ifr_ifru.ifru_data
- SIOCGPPP* ioctls are defines as SIOCDEVPRIVATE + n, so they'd kick in for all private ioctls which is defintely wrong.to implement proper ppp
compat_ioctlhandlig we'd need acompat_ioctlmethod in structnet_device, which we don't have yet.
While I agree that this is theoretically wrong, the problem is that if we remove them, people using ppp on 64-bit PA machines will no longer be able to do so. And yes, there are some, that's why these got added in the first place.
Perhaps I'll look into the compat_ioctl route later. In any case, I would prefer this patch not be added for the moment.
_______________________________________________
parisc-linux mailing list [email protected]
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux