Skip to contentSkip to conversation

ext3: Fix warning without quota support (was: Linux 2.6.14)

PATCH Nick Warne 2 participants 3 messages Nov 12, 2005

lore
Share & tools
lore

Nick Warne

author
#0 lore raw
Quoted 7 lines

Sorry for not spotting this one earlier...

Fix the following warning when ext3 fs is compiled without quota support:

fs/ext3/super.c: In function `ext3_show_options':
fs/ext3/super.c:516: warning: unused variable `sbi'

I have added this small fix to my 2.6.14.2 build. A quick question.

What does GCC do here - does it just drop and ignore the unused variable?

Nick

Signature · 4 lines
http://sourceforge.net/projects/quake2plus

"Person who say it cannot be done should not interrupt person doing it."
-Chinese Proverb
#1 lore raw

Hi Nick,

Quoted 7 lines
Quoted 5 lines

Fix the following warning when ext3 fs is compiled without quota support:

fs/ext3/super.c: In function `ext3_show_options':
fs/ext3/super.c:516: warning: unused variable `sbi'

I have added this small fix to my 2.6.14.2 build. A quick question.

Let is be noted that this warning was fixed in a completely different way in Linus' tree already. My patch is not meant for -stable either, as it doesn't fix any real problem.

Quoted 1 line

What does GCC do here - does it just drop and ignore the unused variable?

Without optimizations, gcc 3.3.6 keeps the variable although it won't ever be used. With -O1 and above (including -Os) it drops the unused variable.

Signature · 1 line
Jean Delvare
author
#2 lore raw

Hi Jean,

Quoted 7 lines · Jean Delvare

Hi Nick,

Quoted 1 line

I have added this small fix to my 2.6.14.2 build. A quick question.

Let is be noted that this warning was fixed in a completely different way in Linus' tree already. My patch is not meant for -stable either, as it doesn't fix any real problem.

I see (or didn't). Isn't it hard to keep up with all this. Kernel developers are unstoppable... how Linus/Andrew/Alan/all_the_rest keep on top of it all I don't know - wonderful stuff.

Quoted 5 lines
Quoted 1 line

What does GCC do here - does it just drop and ignore the unused variable?

Without optimizations, gcc 3.3.6 keeps the variable although it won't ever be used. With -O1 and above (including -Os) it drops the unused variable.

Thanks! I didn't know that at all.

Nick

Signature · 4 lines
http://sourceforge.net/projects/quake2plus

"Person who say it cannot be done should not interrupt person doing it."
-Chinese Proverb