Skip to contentSkip to conversation

hwmon: Fix missing boundary check when setting

PATCH New Jean Delvare 1 participant 1 message Nov 14, 2005 Hardware monitoring

lore
Share & tools
lore

Jean Delvare

author
#0 lore raw

PATCH 1/1 hwmon: Fix missing boundary check when setting

Hi Greg,

This one is for 2.6.15-rc2, and a candidate for -stable.

Thanks.

* * * * *

From: Yuan Mu <[email protected]>
Content-Disposition: inline; filename=hwmon-w83627hf-missing-in0-limit-check.patch

Add SENSORS_LIMIT in store VCore limit functions. This fixes a potential u8 overflow on out-of-range user input.

Signed-off-by Jean Delvare <[email protected]>

---

 drivers/hwmon/w83627hf.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/hwmon/w83627hf.c +4 -2
@@ -456,7 +456,9 @@
 		(w83627thf = data->type || w83637hf = data->type))
 
 		/* use VRM9 calculation */
-		data->in_min[0] = (u8)(((val * 100) - 70000 + 244) / 488);
+		data->in_min[0] +			SENSORS_LIMIT(((val * 100) - 70000 + 244) / 488, 0,
+					255);
 	else
 		/* use VRM8 (standard) calculation */
 		data->in_min[0] = IN_TO_REG(val);

@@ -481,7 +483,9 @@
 		(w83627thf = data->type || w83637hf = data->type))
 		
 		/* use VRM9 calculation */
-		data->in_max[0] = (u8)(((val * 100) - 70000 + 244) / 488);
+		data->in_max[0] +			SENSORS_LIMIT(((val * 100) - 70000 + 244) / 488, 0,
+					255);
 	else
 		/* use VRM8 (standard) calculation */
 		data->in_max[0] = IN_TO_REG(val);
Signature · 1 line
Jean Delvare