drivers/edac/: cleanups

PATCH New Adrian Bunk 1 participant 1 message Nov 18, 2005

Subsystems (3)

EDAC-core EDAC-E752X EDAC-E7XXX

lore

Share & tools

lore

Adrian Bunk

author

2005-11-18 03:33 UTC #0 lore raw

PATCH 1/1 drivers/edac/: cleanups

This patch contains the following cleanups:
- make needlessly global code static
- e752x_edac.c: #if 0 the unused sysbus_message

Signed-off-by Adrian Bunk <[email protected]>

---

 drivers/edac/amd76x_edac.c  |    2 +-
 drivers/edac/e752x_edac.c   |   12 +++++++-----
 drivers/edac/e7xxx_edac.c   |    2 +-
 drivers/edac/edac_mc.c      |    2 +-
 drivers/edac/i82860_edac.c  |    2 +-
 drivers/edac/i82875p_edac.c |    2 +-
 drivers/edac/r82600_edac.c  |    2 +-
 7 files changed, 13 insertions(+), 11 deletions(-)

drivers/edac/amd76x_edac.c renamed from drivers/edac/amd76x_edac.c.old +1 -1

@@ -338,7 +338,7 @@
 	.id_table = amd76x_pci_tbl,
 };
 
-int __init amd76x_init(void)
+static int __init amd76x_init(void)
 {
 	return pci_module_init(&amd76x_driver);
 }

drivers/edac/e752x_edac.c renamed from drivers/edac/e752x_edac.c.old +7 -5

@@ -376,14 +376,14 @@
 		       mci->mc_idx);
 }
 
-char *global_message[11] = {
+static char *global_message[11] = {
 	"PCI Express C1", "PCI Express C", "PCI Express B1",
 	"PCI Express B", "PCI Express A1", "PCI Express A",
 	"DMA Controler", "HUB Interface", "System Bus",
 	"DRAM Controler", "Internal Buffer"
 };
 
-char *fatal_message[2] = { "Non-Fatal ", "Fatal " };
+static char *fatal_message[2] = { "Non-Fatal ", "Fatal " };
 
 static void do_global_error(int fatal, u32 errors)
 {

@@ -405,7 +405,7 @@
 		do_global_error(fatal, errors);
 }
 
-char *hub_message[7] = {
+static char *hub_message[7] = {
 	"HI Address or Command Parity", "HI Illegal Access",
 	"HI Internal Parity", "Out of Range Access",
 	"HI Data Parity", "Enhanced Config Access",

@@ -432,7 +432,7 @@
 		do_hub_error(fatal, errors);
 }
 
-char *membuf_message[4] = {
+static char *membuf_message[4] = {
 	"Internal PMWB to DRAM parity",
 	"Internal PMWB to System Bus Parity",
 	"Internal System Bus or IO to PMWB Parity",

@@ -458,6 +458,7 @@
 		do_membuf_error(errors);
 }
 
+#if 0
 char *sysbus_message[10] = {
 	"Addr or Request Parity",
 	"Data Strobe Glitch",

@@ -469,6 +470,7 @@
 	"Memory Parity",
 	"IO Subsystem Parity"
 };
+#endif  /*  0  */
 
 static void do_sysbus_error(int fatal, u32 errors)
 {

@@ -1044,7 +1046,7 @@
 };
 
 
-int __init e752x_init(void)
+static int __init e752x_init(void)
 {
 	int pci_rc;

drivers/edac/e7xxx_edac.c renamed from drivers/edac/e7xxx_edac.c.old +1 -1

@@ -537,7 +537,7 @@
 };
 
 
-int __init e7xxx_init(void)
+static int __init e7xxx_init(void)
 {
 	return pci_module_init(&e7xxx_driver);
 }

drivers/edac/edac_mc.c renamed from drivers/edac/edac_mc.c.old +1 -1

@@ -1094,7 +1094,7 @@
  * edac_mc_init
  *      module initialization entry point
  */
-int __init edac_mc_init(void)
+static int __init edac_mc_init(void)
 {
 	int ret;
 	struct completion event;

drivers/edac/i82860_edac.c renamed from drivers/edac/i82860_edac.c.old +1 -1

@@ -253,7 +253,7 @@
 	.id_table = i82860_pci_tbl,
 };
 
-int __init i82860_init(void)
+static int __init i82860_init(void)
 {
 	int pci_rc;

drivers/edac/i82875p_edac.c renamed from drivers/edac/i82875p_edac.c.old +1 -1

@@ -483,7 +483,7 @@
 };
 
 
-int __init i82875p_init(void)
+static int __init i82875p_init(void)
 {
 	int pci_rc;

drivers/edac/r82600_edac.c renamed from drivers/edac/r82600_edac.c.old +1 -1

@@ -381,7 +381,7 @@
 };
 
 
-int __init r82600_init(void)
+static int __init r82600_init(void)
 {
 	return pci_module_init(&r82600_driver);
 }