drivers/scsi/: small cleanups
PATCH 1/1 drivers/scsi/: small cleanups
This patch contains the following cleanups:
- make needlessly global functions static
- every file should #include the headers containing the prototypes for it's global functions
Signed-off-by Adrian Bunk <[email protected]>
---
drivers/scsi/scsi_sysctl.c | 1 + drivers/scsi/scsi_sysfs.c | 3 ++- drivers/scsi/scsi_transport_fc.c | 2 +- drivers/scsi/sr.c | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-)
drivers/scsi/scsi_sysfs.c renamed from drivers/scsi/scsi_sysfs.c.old +2 -1
@@ -17,6 +17,7 @@#include <scsi/scsi_host.h> #include <scsi/scsi_tcq.h> #include <scsi/scsi_transport.h> +#include <scsi/scsi_driver.h> #include "scsi_priv.h" #include "scsi_logging.h"
@@ -720,7 +721,7 @@ }EXPORT_SYMBOL (scsi_remove_device); -void __scsi_remove_target (struct scsi_target *starget) +static void __scsi_remove_target (struct scsi_target *starget) {struct Scsi_Host *shost =dev_to_shost (starget->dev.parent);unsigned long flags;
drivers/scsi/scsi_sysctl.c renamed from drivers/scsi/scsi_sysctl.c.old +1 -0
@@ -9,6 +9,7 @@#include <linux/sysctl.h> #include "scsi_logging.h" +#include "scsi_priv.h" static ctl_table scsi_table[] = {
drivers/scsi/scsi_transport_fc.c renamed from drivers/scsi/scsi_transport_fc.c.old +1 -1
@@ -1274,7 +1274,7 @@* Notes: * This routine assumes no locks are held on entry. **/ -struct fc_rport * +static struct fc_rport *fc_rport_create (struct Scsi_Host *shost,int channel,struct fc_rport_identifiers *ids) {
drivers/scsi/sr.c renamed from drivers/scsi/sr.c.old +1 -1
@@ -170,7 +170,7 @@* an inode for that to work, and we do not always have one. */ -int sr_media_change (struct cdrom_device_info *cdi,int slot) +static int sr_media_change (struct cdrom_device_info *cdi,int slot) {struct scsi_cd *cd = cdi->handle;int retval;