Skip to contentSkip to conversation

fs/hfsplus/: move the hfsplus_inode_check() prototype to hfsplus_fs.h

PATCH In review Adrian Bunk 2 participants 4 messages Nov 23, 2005 Hfsplus filesystem

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 fs/hfsplus/: move the hfsplus_inode_check() prototype to hfsplus_fs.h

Function prototypes belong into header files.

Signed-off-by Adrian Bunk <[email protected]>

---

 fs/hfsplus/hfsplus_fs.h |    3 +++
 fs/hfsplus/inode.c      |    2 --
 2 files changed, 3 insertions(+), 2 deletions(-)
fs/hfsplus/hfsplus_fs.h renamed from fs/hfsplus/hfsplus_fs.h.old +3 -0
@@ -347,6 +347,9 @@
 void hfsplus_fill_defaults(struct hfsplus_sb_info *);
 int hfsplus_show_options(struct seq_file *, struct vfsmount *);
 
+/* super.c */
+void hfsplus_inode_check(struct super_block *sb);
+
 /* tables.c */
 extern u16 hfsplus_case_fold_table[];
 extern u16 hfsplus_decompose_table[];
fs/hfsplus/inode.c renamed from fs/hfsplus/inode.c.old +0 -2
@@ -183,7 +183,6 @@
 	hlist_add_head(&inode->i_hash, &HFSPLUS_SB(sb).rsrc_inodes);
 	mark_inode_dirty(inode);
 	{
-	void hfsplus_inode_check(struct super_block *sb);
 	atomic_inc(&HFSPLUS_SB(sb).inode_cnt);
 	hfsplus_inode_check(sb);
 	}

@@ -322,7 +321,6 @@
 		return NULL;
 
 	{
-	void hfsplus_inode_check(struct super_block *sb);
 	atomic_inc(&HFSPLUS_SB(sb).inode_cnt);
 	hfsplus_inode_check(sb);
 	}
#1 lore raw
Quoted 1 line · Adrian Bunk

Function prototypes belong into header files.

I'd like to see someone fix kernel/power/disk.c also....

Signature · 1 line
~Randy
author
#2 lore raw
Quoted 5 lines · Randy.Dunlap
Quoted 1 line · Adrian Bunk

Function prototypes belong into header files.

I'd like to see someone fix kernel/power/disk.c also....

This will also be done before I'll submit my patch to add -Wmissing-prototypes to the global CFLAGS - but I can't fix all places in the kernel at the same day, there are too many of them...

Quoted 1 line

~Randy

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#3 lore raw
Quoted 10 lines · Adrian Bunk
Quoted 5 lines · Randy.Dunlap
Quoted 1 line · Adrian Bunk

Function prototypes belong into header files.

I'd like to see someone fix kernel/power/disk.c also....

This will also be done before I'll submit my patch to add -Wmissing-prototypes to the global CFLAGS - but I can't fix all places in the kernel at the same day, there are too many of them...

Of course, I didn't expect them to be fixed in one day or even for you to be the only person who may do it.

Thanks,

Signature · 1 line
~Randy