Skip to contentSkip to conversation

drivers/message/i2o/pci.c: fix a NULL pointer dereference

PATCH In review Adrian Bunk 2 participants 2 messages Nov 26, 2005 – Nov 27, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/message/i2o/pci.c: fix a NULL pointer dereference

The Coverity checker spotted this obvious NULL pointer dereference.

---

This patch was already sent on:
- 23 Nov 2005
- 21 Nov 2005

drivers/message/i2o/pci.c renamed from drivers/message/i2o/pci.c.old +1 -1
@@ -421,8 +421,8 @@
 	i2o_pci_free(c);
 
       free_controller:
-	i2o_iop_free(c);
 	put_device(c->device.parent);
+	i2o_iop_free(c);
 
       disable:
 	pci_disable_device(pdev);
#1 lore raw

Hello,

Quoted 2 lines · Adrian Bunk

The Coverity checker spotted this obvious NULL pointer dereference.

Quoted 3 lines

This patch was already sent on:
- 23 Nov 2005
- 21 Nov 2005

Sorry, didn't know i have to answer to it. Next time i will respond earlier.

Thank you very much for this patch!

Quoted 12 lines
drivers/message/i2o/pci.c renamed from drivers/message/i2o/pci.c.old +1 -1
@@ -421,8 +421,8 @@
 	i2o_pci_free(c);
 
       free_controller:
-	i2o_iop_free(c);
 	put_device(c->device.parent);
+	i2o_iop_free(c);
 
       disable:
 	pci_disable_device(pdev);