Don't panic on IDE DMA errors
PATCH 1/1 Don't panic on IDE DMA errors
diff-tree e8f3e8dd41308fb66c026f51bb86b23205ad48c1 (from 0b85d6aa75faefe28d90362424035ef7b349974c)
Author: Chris Ross <[email protected]> Date: Wed Nov 23 15:56:00 2005 +0000
[PATCH] Don't panic on IDE DMA errors
Kernel 2.4.32 and earlier can panic when trying to read a corrupted sector from an IDE disk.
The function ide_dma_timeout_retry can end a request early by calling idedisk_error, but then goes on to use the request anyway causing a kernel panic due to a null pointer exception. This patch fixes that.
drivers/ide/ide-io.c +7 -5
@@ -899,11 +899,13 @@ static ide_startstop_t ide_dma_timeout_r rq =HWGROUP (drive)->rq;HWGROUP (drive)->rq =NULL ; - rq->errors =0 ; - rq->sector = rq->bh->b_rsector; - rq->current_nr_sectors = rq->bh->b_size >>9 ; - rq->hard_cur_sectors = rq->current_nr_sectors; - rq->buffer = rq->bh->b_data; +if (rq) { + rq->errors =0 ; + rq->sector = rq->bh->b_rsector; + rq->current_nr_sectors = rq->bh->b_size >>9 ; + rq->hard_cur_sectors = rq->current_nr_sectors; + rq->buffer = rq->bh->b_data; + }return ret; }
What was the panic base on error?
It should have aborted the request and block resends it. However, the logic seems sane and if the request is lost on error this would corrupt if it did not panic.
Is there a clear way to reproduce this in a controlled manner?
IE the goal would be to test data integerity on the events.
Cheers,
Andre Hedrick
LAD Storage Consulting Group
Quoted 44 lines · Marcelo Tosatti
diff-tree
e8f3e8dd41308fb66c026f51bb86b23205ad48c1(from0b85d6aa75faefe28d90362424035ef7b349974c)Author: Chris Ross <[email protected]> Date: Wed Nov 23 15:56:00 2005 +0000[PATCH] Don't panic on IDE DMA errors
Kernel 2.4.32 and earlier can panic when trying to read a corrupted sector from an IDE disk.
The function
ide_dma_timeout_retrycan end a request early by callingidedisk_error, but then goes on to use the request anyway causing a kernel panic due to a null pointer exception. This patch fixes that.drivers/ide/ide-io.c +7
-6@@ -899,11 +899,13 @@ static ide_startstop_t ide_dma_timeout_r rq =HWGROUP (drive)->rq;HWGROUP (drive)->rq =NULL ; - rq->errors =0 ; - rq->sector = rq->bh->b_rsector; - rq->current_nr_sectors = rq->bh->b_size >>9 ; - rq->hard_cur_sectors = rq->current_nr_sectors; - rq->buffer = rq->bh->b_data; +if (rq) { + rq->errors =0 ; + rq->sector = rq->bh->b_rsector; + rq->current_nr_sectors = rq->bh->b_size >>9 ; + rq->hard_cur_sectors = rq->current_nr_sectors; + rq->buffer = rq->bh->b_data; + }return ret; } -To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Hi Andre,
Andre Hedrick escreveu:
Quoted 1 line
What was the panic base on error?
This thread covers the initial discovery and diagnosis of the bug...
http://lists.arm.linux.org.uk/pipermail/linux-arm-kernel/2005-November/032464.html
Regards,
Chris R.