Skip to contentSkip to conversation

Remove duplicated code in vcpu_pause/domain_pause

PATCH New Tony Breeds 1 participant 1 message Nov 30, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove duplicated code in vcpu_pause/domain_pause

Hi All,
Looking at xen/common/domain.c, I saw that domain_pause
duplicates the code from VIP_pause. This patch eliminates the duplicate code and makes domain pause a mirror for the existing domain_unpause.

Is there a reason not to do this?

-----------------

xen/common/domain.c +1 -5
diff -r ccf76e51e7e6 xen/common/domain.c
@@ -293,11 +293,7 @@
     struct vcpu *v;
 
     for_each_vcpu( d, v )
-    {
-        BUG_ON(v == current);
-        atomic_inc(&v->pausecnt);
-        vcpu_sleep_sync(v);
-    }
+	vcpu_pause(v);
 
     sync_pagetable_state(d);
 }

Yours Tony

linux.conf.au http://linux.conf.au/ || http://lca2006.linux.org.au/
Jan 23-28 2006 The Australian Linux Technical Conference!