Skip to contentSkip to conversation

make i2o_iop_free() static inline

PATCH In review Adrian Bunk 2 participants 2 messages Dec 3, 2005 – Dec 4, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 make i2o_iop_free() static inline

It's only a micro-optimizatin, but why not save a few bytes?

drivers/message/i2o/core.h renamed from drivers/message/i2o/core.h.old +9 -1
@@ -38,7 +38,15 @@
 
 /* IOP */
 extern struct i2o_controller *i2o_iop_alloc(void);
-extern void i2o_iop_free(struct i2o_controller *);
+
+/**
+ *	i2o_iop_free - Free the i2o_controller struct
+ *	@c: I2O controller to free
+ */
+static inline void i2o_iop_free(struct i2o_controller *c)
+{
+	kfree(c);
+}
 
 extern int i2o_iop_add(struct i2o_controller *);
 extern void i2o_iop_remove(struct i2o_controller *);
drivers/message/i2o/iop.c renamed from drivers/message/i2o/iop.c.old +0 -9
@@ -1051,15 +1051,6 @@
 }
 
 /**
- *	i2o_iop_free - Free the i2o_controller struct
- *	@c: I2O controller to free
- */
-void i2o_iop_free(struct i2o_controller *c)
-{
-	kfree(c);
-};
-
-/**
  *	i2o_iop_release - release the memory for a I2O controller
  *	@dev: I2O controller which should be released
  *
#1 lore raw

Hello,

Quoted 1 line · Adrian Bunk

It's only a micro-optimizatin, but why not save a few bytes?

I fully agree :-)

Thanks!

Quoted 1 line

Best regards,

Markus Lidel
------------------------------------------
Markus Lidel (Senior IT Consultant)

Shadow Connect GmbH
Carl-Reisch-Weg 12
D-86381 Krumbach
Germany

Phone:  +49 82 82/99 51-0
Fax:    +49 82 82/99 51-11
E-Mail: [email protected]
URL:    http://www.shadowconnect.com