Skip to contentSkip to conversation

Proper check of SCR error code

PATCH Applied Pierre Ossman 2 participants 2 messages Dec 4, 2005 – Dec 5, 2005 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Proper check of SCR error code

The routine reading the SCR wasn't paying proper attention to the error codes returned from the driver.

---

 drivers/mmc/mmc.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
drivers/mmc/mmc.c +3 -2
index d336a1d..b586a83 100644
@@ -932,8 +932,9 @@ static void mmc_read_scrs(struct mmc_hos
 
 		sg_init_one(&sg, (u8*)card->raw_scr, 8);
 
-		err = mmc_wait_for_req(host, &mrq);
-		if (err != MMC_ERR_NONE) {
+		mmc_wait_for_req(host, &mrq);
+
+		if (cmd.error != MMC_ERR_NONE || data.error != MMC_ERR_NONE) {
 			mmc_card_set_dead(card);
 			continue;
 		}
Applied
#1 lore raw
Quoted 2 lines · Pierre Ossman

The routine reading the SCR wasn't paying proper attention to the error codes returned from the driver.

Applied, thanks Pierre.

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core