Skip to contentSkip to conversation

usb-serial: cyberjack driver port.

PATCH In review Luiz Fernando Capitulino 1 participant 1 message Dec 6, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 3/10 usb-serial: cyberjack driver port.

Ports the cyberjack driver from write_urb_busy spin_lock to
usb_serial_write_urb_lock() functions.

 drivers/usb/serial/cyberjack.c |   12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)
drivers/usb/serial/cyberjack.c +4 -8
diff -Nparu -X /home/lcapitulino/kernels/dontdiff a/drivers/usb/serial/cyberjack.c a~/drivers/usb/serial/cyberjack.c
@@ -215,14 +215,10 @@ static int cyberjack_write (struct usb_s
 		return (0);
 	}
 
-	spin_lock(&port->lock);
-	if (port->write_urb_busy) {
-		spin_unlock(&port->lock);
+	if (usb_serial_write_urb_lock(port)) {
 		dbg("%s - already writing", __FUNCTION__);
 		return 0;
 	}
-	port->write_urb_busy = 1;
-	spin_unlock(&port->lock);
 
 	spin_lock_irqsave(&priv->lock, flags);
 
@@ -230,7 +226,7 @@ static int cyberjack_write (struct usb_s
 		/* To much data for buffer. Reset buffer. */
 		priv->wrfilled=0;
 		spin_unlock_irqrestore(&priv->lock, flags);
-		port->write_urb_busy = 0;
+		usb_serial_write_urb_unlock(port);
 		return (0);
 	}
 
@@ -275,7 +271,7 @@ static int cyberjack_write (struct usb_s
 			priv->wrfilled=0;
 			priv->wrsent=0;
 			spin_unlock_irqrestore(&priv->lock, flags);
-			port->write_urb_busy = 0;
+			usb_serial_write_urb_unlock(port);
 			return 0;
 		}
 
@@ -421,7 +417,7 @@ static void cyberjack_write_bulk_callbac
 
 	dbg("%s - port %d", __FUNCTION__, port->number);
 
-	port->write_urb_busy = 0;
+	usb_serial_write_urb_unlock(port);
 	if (urb->status) {
 		dbg("%s - nonzero write bulk status received: %d", __FUNCTION__, urb->status);
 		return;
Signature · 1 line
Luiz Fernando N. Capitulino