Skip to contentSkip to conversation

kernel-2.6.15-rc5-rt2 - compilation error ‘RWSEM_ACTIVE_BIAS’ undeclared

DISCUSSION art 3 participants 5 messages Dec 14, 2005 – Dec 15, 2005

lore
Share & tools
lore

art

author
#0 lore raw

kernel-2.6.15-rc5-rt2 - compilation error ‘RWSEM_ACTIVE_BIAS’ undeclared

gcc version 4.0.2
........

  CC      lib/kref.o
  CC      lib/prio_tree.o
  CC      lib/radix-tree.o
  CC      lib/rbtree.o
  CC      lib/rwsem.o

lib/rwsem.c: In function ‘__rwsem_do_wake’:
lib/rwsem.c:57: warning: implicit declaration of function ‘rwsem_atomic_update’ lib/rwsem.c:57: error: ‘RWSEM_ACTIVE_BIAS’ undeclared (first use in this function) lib/rwsem.c:57: error: (Each undeclared identifier is reported only once lib/rwsem.c:57: error: for each function it appears in.) lib/rwsem.c:59: error: ‘RWSEM_ACTIVE_MASK’ undeclared (first use in this function) lib/rwsem.c:62: error: ‘struct rw_semaphore’ has no member named ‘wait_list’ lib/rwsem.c:85: error: ‘struct rw_semaphore’ has no member named ‘wait_list’ lib/rwsem.c:99: error: ‘struct rw_semaphore’ has no member named ‘wait_list’ lib/rwsem.c:108: error: ‘RWSEM_WAITING_BIAS’ undeclared (first use in this function) lib/rwsem.c:113: warning: implicit declaration of function ‘rwsem_atomic_add’ lib/rwsem.c:115: error: ‘struct rw_semaphore’ has no member named ‘wait_list’ lib/rwsem.c:126: error: ‘struct rw_semaphore’ has no member named ‘wait_list’ lib/rwsem.c:127: error: ‘struct rw_semaphore’ has no member named ‘wait_list’ lib/rwsem.c: In function ‘rwsem_down_failed_common’:
lib/rwsem.c:153: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ lib/rwsem.c:153: warning: type defaults to ‘int’ in declaration of ‘type name’ lib/rwsem.c:153: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ lib/rwsem.c:153: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ lib/rwsem.c:153: warning: type defaults to ‘int’ in declaration of ‘type name’ lib/rwsem.c:153: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ lib/rwsem.c:157: error: ‘struct rw_semaphore’ has no member named ‘wait_list’ lib/rwsem.c:163: error: ‘RWSEM_ACTIVE_MASK’ undeclared (first use in this function) lib/rwsem.c:166: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ lib/rwsem.c:166: warning: type defaults to ‘int’ in declaration of ‘type name’ lib/rwsem.c:166: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ lib/rwsem.c:166: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ lib/rwsem.c:166: warning: type defaults to ‘int’ in declaration of ‘type name’ lib/rwsem.c:166: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ lib/rwsem.c: In function ‘rwsem_down_read_failed’:
lib/rwsem.c:193: error: ‘RWSEM_WAITING_BIAS’ undeclared (first use in this function) lib/rwsem.c:193: error: ‘RWSEM_ACTIVE_BIAS’ undeclared (first use in this function) lib/rwsem.c: In function ‘rwsem_down_write_failed’:
lib/rwsem.c:210: error: ‘RWSEM_ACTIVE_BIAS’ undeclared (first use in this function) lib/rwsem.c: In function ‘rwsem_wake’:
lib/rwsem.c:226: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ lib/rwsem.c:226: warning: type defaults to ‘int’ in declaration of ‘type name’ lib/rwsem.c:226: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ lib/rwsem.c:226: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ lib/rwsem.c:226: warning: type defaults to ‘int’ in declaration of ‘type name’ lib/rwsem.c:226: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ lib/rwsem.c:229: error: ‘struct rw_semaphore’ has no member named ‘wait_list’ lib/rwsem.c:232: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ lib/rwsem.c:232: warning: type defaults to ‘int’ in declaration of ‘type name’ lib/rwsem.c:232: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ lib/rwsem.c:232: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ lib/rwsem.c:232: warning: type defaults to ‘int’ in declaration of ‘type name’ lib/rwsem.c:232: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ lib/rwsem.c: In function ‘rwsem_downgrade_wake’:
lib/rwsem.c:250: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ lib/rwsem.c:250: warning: type defaults to ‘int’ in declaration of ‘type name’ lib/rwsem.c:250: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ lib/rwsem.c:250: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ lib/rwsem.c:250: warning: type defaults to ‘int’ in declaration of ‘type name’ lib/rwsem.c:250: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ lib/rwsem.c:253: error: ‘struct rw_semaphore’ has no member named ‘wait_list’ lib/rwsem.c:256: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ lib/rwsem.c:256: warning: type defaults to ‘int’ in declaration of ‘type name’ lib/rwsem.c:256: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ lib/rwsem.c:256: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ lib/rwsem.c:256: warning: type defaults to ‘int’ in declaration of ‘type name’ lib/rwsem.c:256: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ make[1]: *** [lib/rwsem.o] Error 1
make: *** [lib] Error 2

xboom

#1 lore raw
Quoted 11 lines · art

kernel-2.6.15-rc5-rt2 - compilation error ‘RWSEM_ACTIVE_BIAS’ undeclared

gcc version 4.0.2
........

  CC      lib/kref.o
  CC      lib/prio_tree.o
  CC      lib/radix-tree.o
  CC      lib/rbtree.o
  CC      lib/rwsem.o

lib/rwsem.c: In function ‘__rwsem_do_wake’:
lib/rwsem.c:57: warning: implicit declaration of function ‘rwsem_atomic_update’

...

Quoted 8 lines

lib/rwsem.c:256: warning: type defaults to ‘int’ in declaration of ‘type name’ lib/rwsem.c:256: error: ‘struct rw_semaphore’ has no member named ‘wait_lock’ make[1]: *** [lib/rwsem.o] Error 1
make: *** [lib] Error 2

xboom

-

.config please.

-- Steve

#2 lore raw

Re: kernel-2.6.15-rc5-rt2 - compilation error

In reply to art

Ingo,

x86_64 wont compile without PREEMPT_RT. It must regardless of PREEMPT_RT have RWSEM_GENERIC_SPINLOCK.

-- Steve

arch/x86_64/Kconfig +0 -5
Index: linux-2.6.15-rc5-rt2/arch/x86_64/Kconfig
===================================================================
@@ -240,13 +240,8 @@
 
 config RWSEM_GENERIC_SPINLOCK
 	bool
-	depends on PREEMPT_RT
 	default y
 
-config RWSEM_XCHGADD_ALGORITHM
-	depends on !RWSEM_GENERIC_SPINLOCK && !PREEMPT_RT
-	bool
-
 config K8_NUMA
        bool "Old style AMD Opteron NUMA detection"
        depends on NUMA
#3 lore raw
In reply to art
Quoted 4 lines · art

kernel-2.6.15-rc5-rt2 - compilation error ‘RWSEM_ACTIVE_BIAS’ undeclared

gcc version 4.0.2
........

Quoted 8 lines
  CC      lib/kref.o
  CC      lib/prio_tree.o
  CC      lib/radix-tree.o
  CC      lib/rbtree.o
  CC      lib/rwsem.o

lib/rwsem.c: In function ‘__rwsem_do_wake’:
lib/rwsem.c:57: warning: implicit declaration of function ‘rwsem_atomic_update’ lib/rwsem.c:57: error: ‘RWSEM_ACTIVE_BIAS’ undeclared (first use in this function)

Art,

Use this patch.

Ingo,

Could you please apply this.

-- Steve

arch/i386/Kconfig +1 -2
Index: linux-2.6.15-rc5-rt2/arch/i386/Kconfig
===================================================================
@@ -245,8 +245,7 @@
 
 config RWSEM_XCHGADD_ALGORITHM
 	bool
-	depends on !RWSEM_GENERIC_SPINLOCK && !PREEMPT_RT
-	default y
+	default y if !RWSEM_GENERIC_SPINLOCK
 
 config X86_UP_APIC
 	bool "Local APIC support on uniprocessors"
arch/i386/Kconfig.cpu +0 -5
Index: linux-2.6.15-rc5-rt2/arch/i386/Kconfig.cpu
===================================================================
@@ -229,11 +229,6 @@
 	depends on M386
 	default y
 
-config RWSEM_XCHGADD_ALGORITHM
-	bool
-	depends on !M386
-	default y
-
 config GENERIC_CALIBRATE_DELAY
 	bool
 	default y
#4 lore raw
In reply to art

Same problem here on x86 architecture.
It already exists with rt1.

mercredi 14 Décembre 2005 18:57, art wrote/a écrit :

Quoted 16 lines

kernel-2.6.15-rc5-rt2 - compilation error ‘RWSEM_ACTIVE_BIAS’ undeclared

gcc version 4.0.2
........

  CC      lib/kref.o
  CC      lib/prio_tree.o
  CC      lib/radix-tree.o
  CC      lib/rbtree.o
  CC      lib/rwsem.o

lib/rwsem.c: In function ‘__rwsem_do_wake’:
lib/rwsem.c:57: warning: implicit declaration of function ‘rwsem_atomic_update’ lib/rwsem.c:57: error: ‘RWSEM_ACTIVE_BIAS’ undeclared (first use in this function) lib/rwsem.c:57: error: (Each undeclared identifier is reported only once lib/rwsem.c:57: error: for each function it appears in.) lib/rwsem.c:59: error: ‘RWSEM_ACTIVE_MASK’ undeclared (first use in this function)

...