Skip to contentSkip to conversation

remove CONFIG_UID16

PATCH New Adrian Bunk 4 participants 6 messages Dec 17, 2005 – Dec 22, 2005

lore
Share & tools
lore
#0 lore raw

It seems noone noticed that CONFIG_UID16 was accidentially always disabled in the latest -mm kernels.

Is there any reason against removing it completely?

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#1 lore raw
Quoted 4 lines · Adrian Bunk

It seems noone noticed that CONFIG_UID16 was accidentially always disabled in the latest -mm kernels.

Is there any reason against removing it completely?

Yes, it breaks backwards-compatilbity for not even that old binaries.

There's not way we're ever going to remove it.

#2 lore raw
Quoted 9 lines · Christoph Hellwig
Quoted 4 lines · Adrian Bunk

It seems noone noticed that CONFIG_UID16 was accidentially always disabled in the latest -mm kernels.

Is there any reason against removing it completely?

Yes, it breaks backwards-compatilbity for not even that old binaries.

There's not way we're ever going to remove it.

You are right.

Sorry, this was a dumb idea

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#4 lore raw
In reply to Adrian Bunk
Quoted 2 lines · Adrian Bunk

It seems noone noticed that CONFIG_UID16 was accidentially always disabled in the latest -mm kernels.

Hmm, did I break it?

Signature · 1 line
Mathematics is the supreme nostalgia of our time.
#5 lore raw

PATCH 1/1 re-enable UID16 for !EMBEDDED

Quoted 5 lines · Matt Mackall
Quoted 2 lines · Adrian Bunk

It seems noone noticed that CONFIG_UID16 was accidentially always disabled in the latest -mm kernels.

Hmm, did I break it?

Yes, patch below.

cu
Adrian

<-- snip -->

UID16 was accidentially disabled for !EMBEDDED.

init/Kconfig renamed from init/Kconfig.old +1 -0
@@ -337,10 +337,11 @@
 config UID16
 	bool "Enable 16-bit UID system calls" if EMBEDDED
 	depends !ALPHA && !PPC && !PPC64 && !PARISC && !V850 && !ARCH_S390X
 	depends !X86_64 || IA32_EMULATION
 	depends !SPARC64 || SPARC32_COMPAT
+	default y
 	help
 	  This enables the legacy 16-bit UID syscall wrappers.
 
 config CC_OPTIMIZE_FOR_SIZE
 	bool "Optimize for size"
#3 lore raw
In reply to Adrian Bunk
Quoted 8 lines · Adrian Bunk
Quoted 6 lines · Christoph Hellwig
Quoted 3 lines · Adrian Bunk

It seems noone noticed that CONFIG_UID16 was accidentially always disabled in the latest -mm kernels.

Is there any reason against removing it completely?

Quoted 8 lines
Quoted 3 lines

Yes, it breaks backwards-compatilbity for not even that old binaries.

There's not way we're ever going to remove it.

You are right.

Sorry, this was a dumb idea

The question is, did you prove that (a) the people who need it are smart enough to set it, or (b) the people who need it are not testing -mm kernels.

Signature · 3 lines
   -bill davidsen ([email protected])
"The secret to procrastination is to put things off until the
 last possible moment - but no longer"  -me