Skip to contentSkip to conversation

i2c: I2C_DF_NOTIFY removal comment

PATCH New Jean Delvare 1 participant 1 message Dec 18, 2005 I2C

lore
Share & tools
lore
#0 lore raw

PATCH 8/11 i2c: I2C_DF_NOTIFY removal comment

Content-Disposition: inline; filename=i2c-drop-driver-flags-04-drop-outdated-comments.patch

The removal of I2C_DF_NOTIFY left some out of date comments in the code. Drop them.

Signed-off-by Jean Delvare <khali at linux-fr.org>
---
 drivers/i2c/i2c-core.c |    8 --------
 1 file changed, 8 deletions(-)
drivers/i2c/i2c-core.c +0 -8
@@ -246,10 +246,6 @@
 	list_for_each_safe(item, _n, &adap->clients) {
 		client = list_entry(item, struct i2c_client, list);
 
-		/* detaching devices is unconditional of the set notify
-		 * flag, as _all_ clients that reside on the adapter
-		 * must be deleted, as this would cause invalid states.
-		 */
 		if ((res=client->driver->detach_client(client))) {
 			dev_err(&adap->dev, "detach_client failed for client "
 				"[%s] at address 0x%02x\n", client->name,
@@ -335,10 +331,6 @@
 	/* Have a look at each adapter, if clients of this driver are still
 	 * attached. If so, detach them to be able to kill the driver 
 	 * afterwards.
-	 *
-	 * Removing clients does not depend on the notify flag, else
-	 * invalid operation might (will!) result, when using stale client
-	 * pointers.
 	 */
 	list_for_each(item1,&adapters) {
 		adap = list_entry(item1, struct i2c_adapter, list);
Signature · 1 line
Jean Delvare