Linux 2.6.15-rc6
Voluspa
Acked-by Maneesh SoniI know that C1 isn't much of a power save, but that's what my amd64 notebook provides, and it get used in 2.6.14:
loke@sleipner:~$ cat /proc/acpi/processor/CPU0/power active state: C1 max_cstate: C8 bus master activity: 00000000 states: *C1: type[C1] promotion[--] demotion[--] latency[000] usage[01399981]
Not so in 2.6.15-rc2 to -rc6 (report http://marc.theaimsgroup.com/?l=linux-kernel&m=113498252000221&w=2 ) Culprit is the following commit that I humbly ask to be removed/rewritten:
root@sleipner:/home/git/linux-2.6# git bisect bad 2203d6ed448ff3b777ee6bb614a53e686b483e5b is first bad commit diff-tree 2203d6ed448ff3b777ee6bb614a53e686b483e5b (from 2656c076e31a3ce3ab2a987a578e7122dc2af51d) Author: Linus Torvalds <[email protected]> Date: Fri Nov 18 07:29:51 2005 -0800
Fix ACPI processor power block initialization
Properly clear the memory, and set "pr->flags.power" only if a C2 or deeper state is valid (to make the code match both the comment and previous behaviour).
This fixes a boot-time lockup reported by Maneesh Soni when using "maxcpus=1".
:040000 040000 52be621b960ae192b36acf778c966d78ff5edbe2 04c183ce141dab8cdff049c1dae379104b637ed4 M drivers
Mvh
Mats Johannesson
--
Quoted 7 lines · Voluspa
Not so in 2.6.15-rc2 to -rc6 (report http://marc.theaimsgroup.com/?l=linux-kernel&m=113498252000221&w=2 ) Culprit is the following commit that I humbly ask to be removed/rewritten:
2203d6ed448ff3b777ee6bb614a53e686b483e5b:Fix ACPI processor power block initialization
I'd love to have it fixed, but quite frankly, if the choice is between a boot-time lockup and not using ACPI C1 sleep states, I'll take the non-working sleep states.
The code in question had comments that didn't match what it was doing, and apparently the ACPI guys couldn't say what was wrong..
But it might make sense to open a bugzilla entry so that it doesn't get lost.
Linus
On Tue, 20 Dec 2005 21:33:28 -0800 (PST) Linus Torvalds wrote:
[...]
Quoted 8 lines
Quoted 3 lines
2203d6ed448ff3b777ee6bb614a53e686b483e5b:Fix ACPI processor power block initialization
I'd love to have it fixed, but quite frankly, if the choice is between a boot-time lockup and not using ACPI C1 sleep states, I'll take the non-working sleep states.
Quoted 5 lines
The code in question had comments that didn't match what it was doing, and apparently the ACPI guys couldn't say what was wrong..
But it might make sense to open a bugzilla entry so that it doesn't get lost.
No sweat, it's easy to revert locally. I'll open a report once I've registered at the bugzilla.
God Jul (och se upp med revbenen!)
Mats Johannesson
--
On Tue, 20 Dec 2005 21:33:28 -0800 (PST) Linus Torvalds wrote:
[...]
Quoted 2 lines
But it might make sense to open a bugzilla entry so that it doesn't get lost.
http://bugzilla.kernel.org/show_bug.cgi?id=5767
For anyone stumbling into this problem, lacking git experience, here's a 1/10-revert patch that gives me back the former functionality. It behaves exactly as in 2.6.14 with regards to C1 usage and thermal_zone temperatures etc.
drivers/acpi/processor_idle.c +1 -1
@@ -893,7 +893,7 @@for (i =1 ; i <ACPI_PROCESSOR_MAX_POWER ; i++) {if (pr->power.states[i].valid) { pr->power.count = i; -if (pr->power.states[i].type >=ACPI_STATE_C2 ) +if (pr->power.states[i].type >=ACPI_STATE_C1 ) pr->flags.power =1 ; } }
Mvh
Mats Johannesson
--