Skip to contentSkip to conversation

Don't allow CONFIG_PMAC_BACKLIGHT on pmac64

PATCH In review Andi Kleen 3 participants 4 messages Dec 21, 2005 Linux for power macintosh

lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

PATCH 1/1 Don't allow CONFIG_PMAC_BACKLIGHT on pmac64

For 2.6.15rc6-git2

Don't allow to set CONFIG_MAC_BACKLIGHT on pmac64. It won't compile.

Signed-off-by Andi Kleen <[email protected]>
drivers/macintosh/Kconfig renamed from drivers/macintosh/Kconfig-o +1 -1
diff -u linux-2.6.15rc6git2/drivers/macintosh/Kconfig-o linux-2.6.15rc6git2/drivers/macintosh/Kconfig
@@ -103,7 +103,7 @@
 # on non-powerbook machines (but only on PMU based ones AFAIK)
 config PMAC_BACKLIGHT
 	bool "Backlight control for LCD screens"
-	depends on ADB_PMU && (BROKEN || !PPC64)
+	depends on ADB_PMU && !PPC64
 	help
 	  Say Y here to build in code to manage the LCD backlight on a
 	  Macintosh PowerBook.  With this code, the backlight will be turned
#1 lore raw

Hi,

drivers/macintosh/Kconfig line 106

Quoted 4 lines · Andi Kleen

Don't allow to set CONFIG_MAC_BACKLIGHT on pmac64. It won't compile.

drivers/macintosh/Kconfig renamed from drivers/macintosh/Kconfig-o +1 -1
-	depends on ADB_PMU && (BROKEN || !PPC64)
+	depends on ADB_PMU && !PPC64

That's why it's marked BROKEN, perhaps?

Simon

author
#2 lore raw
Quoted 10 lines · Simon Richter

Hi,

drivers/macintosh/Kconfig line 106

Quoted 4 lines · Andi Kleen

Don't allow to set CONFIG_MAC_BACKLIGHT on pmac64. It won't compile.

drivers/macintosh/Kconfig renamed from drivers/macintosh/Kconfig-o +1 -1
-	depends on ADB_PMU && (BROKEN || !PPC64)
+	depends on ADB_PMU && !PPC64

That's why it's marked BROKEN, perhaps?

It didn't work - i could select it.

-Andi

#3 lore raw
Quoted 1 line · Andi Kleen

It didn't work - i could select it.

Are you sure you don't have CONFIG_BROKEN=y?

Paul.