Skip to contentSkip to conversation

mutex subsystem, switch ARM to use the xchg based implementation

PATCH In review Ingo Molnar 1 participant 1 message Dec 22, 2005

Subsystems (2)
Arm (32-bit) Atomic infrastructure
lore
Share & tools
lore

Ingo Molnar

author
#0 lore raw

PATCH 7/10 mutex subsystem, switch ARM to use the xchg based implementation

as noted by Nicolas Pitre, atomic_[inc/dec]_call_if_[nonpositive/negative]() atomic methods are slow on ARM, because they can only be implemented via disabling interrupts. So tell the mutex code that we prefer atomic_xchg().

[ we still pull in asm-generic/atomic-call-if.h, so that they remain
generally available primitives - even though unused on ARM at the moment. ]

Signed-off-by Ingo Molnar <[email protected]>

----

 arch/arm/Kconfig         |    4 ++++
 include/asm-arm/atomic.h |    7 +------
 2 files changed, 5 insertions(+), 6 deletions(-)
arch/arm/Kconfig +4 -0
Index: linux/arch/arm/Kconfig
===================================================================
@@ -50,6 +50,10 @@ config UID16
 	bool
 	default y
 
+config MUTEX_XCHG_ALGORITHM
+	bool
+	default y
+
 config RWSEM_GENERIC_SPINLOCK
 	bool
 	default y
include/asm-arm/atomic.h +1 -6
Index: linux/include/asm-arm/atomic.h
===================================================================
@@ -179,12 +179,7 @@ static inline void atomic_clear_mask(uns
 
 /*
  * Pull in the generic wrappers for atomic_dec_call_if_negative() and
- * atomic_inc_call_if_nonpositive().
- *
- * TODO: implement optimized primitives instead, or leave the generic
- * implementation in place, or enable CONFIG_MUTEX_XCHG_ALGORITHM
- * to tell the generic mutex code to use the atomic_xchg() based
- * fastpath implementation.
+ * atomic_inc_call_if_nonpositive():
  */
 #include <asm-generic/atomic-call-if.h>