Avoid namespace pollution in <asm/param.h>
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 10 lines · Linux Kernel Mailing List
tree
f0d89e7d946a7ed9b57bb29e93bae4ce25d2cbc2
parentf12f4d90308a22396ac87f6c3a7b2620589614c3
author Dag-Erling Sm?rgrav <[email protected]> Mon, 02 Jan 2006 15:57:06 +0100 committer Linus Torvalds <[email protected]> Tue, 03 Jan 2006 00:38:38 -0800[PATCH] Avoid namespace pollution in <
asm/param.h>In commit 3D59121003721a8fad11ee72e646fd9d3076b5679c, the x86 and x86-64 <
asm/param.h> was changed to include <linux/config.h> for the configurable timer frequency.
config.h is always implicit included using -include option to gcc, so the
include/asm-i386/param.h line 1
Quoted 4 lines
include/asm-i386/param.h +0
-1@@ -1,9 +1,8 @@ -#include <linux/config.h>
is redundant and the correct patch would be to get rid of it.
Same goes for:
include/asm-x86_64/param.h line 1
Quoted 4 lines
include/asm-x86_64/param.h +0
-1@@ -1,9 +1,8 @@ -#include <linux/config.h>
Sam
Quoted 3 lines · Sam Ravnborg
config.his always implicit included using -include option to gcc, so the #include <linux/config.h> is redundant and the correct patch would be to get rid of it.
In that case, you have your work cut out for you:
des@xps ~/src/linux-2.6.14.5% grep -r linux/config.h . | wc -l
3777
This is likely to have a significant impact on compilation time...
DES
Signature · 1 line
Dag-Erling Smørgrav - [email protected]