Skip to contentSkip to conversation

fix pnpacpi regression resulting from ACPICA 20051117

PATCH New Len Brown 1 participant 1 message Jan 5, 2006 ACPI

lore
Share & tools
lore

Len Brown

author
#0 lore raw

PATCH 1/1 fix pnpacpi regression resulting from ACPICA 20051117

Andrew,
I just pushed this patch to the test branch of the acpi git tree. Please pull my tree again or apply this patch before you ship the next -mm if possible.

Thanks to Shaohua Li for keeping me awake helping me to fix this:-)

thanks,
-Len

In ACPICA 20051117, acpi_walk_resources() started sending ACPI_RESOURCE_TYPE_END_TAG to the callback routine which wasn't prepared for it, causing _CRS to fail and PnPACPI to not recognize any devices:

pnp: ACPI device : hid PNP0C02
pnp: PnPACPI: unknown resource type 7
pnp: PnPACPI: METHOD_NAME__CRS failure for PNP0c02

---

 drivers/acpi/resources/rsxface.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

ed349a8a0a780ed27e2a765f16cee54d9b63bfee

drivers/acpi/resources/rsxface.c +6 -6
index 50a956b..5408e5d 100644
@@ -286,6 +286,12 @@ acpi_walk_resources(acpi_handle device_h
 			break;
 		}
 
+		/* end_tag indicates end-of-list */
+
+		if (resource->type == ACPI_RESOURCE_TYPE_END_TAG) {
+			break;
+		}
+
 		/* Invoke the user function, abort on any error returned */
 
 		status = user_function(resource, context);
@@ -298,12 +304,6 @@ acpi_walk_resources(acpi_handle device_h
 			break;
 		}
 
-		/* end_tag indicates end-of-list */
-
-		if (resource->type == ACPI_RESOURCE_TYPE_END_TAG) {
-			break;
-		}
-
 		/* Get the next resource descriptor */
 
 		resource =
Signature · 5 lines
1.0.6-g58e3
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html